Add renames in output when using the mirror helper library.

sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart_backend;
 
 // TODO(ahe): This class is simply wrong.  This backend should use
 // elements when it can, not AST nodes.  Perhaps a [Map<Element,
 // TreeElements>] is what is needed.
 class ElementAst {
@@ skipping 246 matching lines @@
     }
     // The VM will automatically invoke the call method of objects
     // that are invoked as functions. Make sure to not rename that.
     fixedMemberNames.add('call');
     // TODO(antonm): TypeError.srcType and TypeError.dstType are defined in
     // runtime/lib/error.dart. Overall, all DartVM specific libs should be
     // accounted for.
     fixedMemberNames.add('srcType');
     fixedMemberNames.add('dstType');
 
+    if (useMirrorHelperLibrary) {
+      useMirrorHelperLibrary = compiler.mirrorsLibrary != null;
+    }
+
     /**
      * Tells whether we should output given element. Corelib classes like
      * Object should not be in the resulting code.
      */
     bool shouldOutput(Element element) {
-      return !identical(element.kind, ElementKind.VOID)
+      return (!identical(element.kind, ElementKind.VOID)

[ahe, 2013/08/19 15:34:06]

Since you're changing this line, would you mind updating it to:

element.kind != ElementKind.VOID

[zarah, 2013/08/20 14:08:17]

Done.

           && isUserLibrary(element.getLibrary())
           && !element.isSynthesized
-          && element is !AbstractFieldElement;
+          && element is !AbstractFieldElement)
+          || element == compiler.mirrorHelperFunction;
     }
 
     final elementAsts = new Map<Element, ElementAst>();
 
     parse(element) => element.parseNode(compiler);
 
     Set<Element> topLevelElements = new Set<Element>();
     Map<ClassElement, Set<Element>> classMembers =
         new Map<ClassElement, Set<Element>>();
 
@@ skipping 104 matching lines @@
           new ElementAst(constructor.cachedNode, new TreeElementMapping(null));
     }
 
     // Create all necessary placeholders.
     PlaceholderCollector collector =
         new PlaceholderCollector(compiler, fixedMemberNames, elementAsts);
     // Add synthesizedIdentifier to set of unresolved names to rename it to
     // some unused identifier.
     collector.unresolvedNodes.add(synthesizedIdentifier);
     makePlaceholders(element) {
-      collector.collect(element);
+      if (useMirrorHelperLibrary &&
+          element.getLibrary() == compiler.mirrorHelperLibrary) {
+        useMirrorHelperLibrary = false;
+        collector.collect(element);
+        useMirrorHelperLibrary = true;

[ahe, 2013/08/19 15:34:06]

I would store the old value. It is always good when building a compiler that
might call its methods recursively as it gets more advanced. Also, it would
allow you to write this (which I find simpler):

bool oldUseHelper = useMirrorHelperLibrary;
useMirrorHelperLibrary = useMirrorHelperLibrary && element.getLibrary() ==
compiler.mirrorHelperLibrary;
collector.collect(element)
useMirrorHelperLibrary = oldUseHelper;

[zarah, 2013/08/20 14:08:17]

Done.

+      } else {
+        collector.collect(element);
+      }
       if (element.isClass()) {
         classMembers[element].forEach(makePlaceholders);
       }
     }
     topLevelElements.forEach(makePlaceholders);
     // Create renames.
     bool shouldCutDeclarationTypes = forceStripTypes
         || (compiler.enableMinification
             && isSafeToRemoveTypeDeclarations(classMembers));
     renamePlaceholders(
@@ skipping 32 matching lines @@
       topLevelNodes.add(elementAsts[element].ast);
       if (element.isClass() && !element.isMixinApplication) {
         final members = <Node>[];
         for (final member in sortedClassMembers[element]) {
           members.add(elementAsts[member].ast);
         }
         memberNodes[elementAsts[element].ast] = members;
       }
     }
 
-    if (useMirrorHelperLibrary && compiler.mirrorsLibrary != null) {
-      MirrorRenamer.addMirrorHelperImport(imports);
+    if (useMirrorHelperLibrary) {
+      MirrorRenamer.addRenames(renames, topLevelNodes, compiler);
     }
 
     final unparser = new EmitterUnparser(renames);
     emitCode(unparser, imports, topLevelNodes, memberNodes);
     compiler.assembledCode = unparser.result;
 
     // Output verbose info about size ratio of resulting bundle to all
     // referenced non-platform sources.
     logResultBundleSizeInfo(topLevelElements);
   }
 
   void logResultBundleSizeInfo(Set<Element> topLevelElements) {
     Iterable<LibraryElement> referencedLibraries =
         compiler.libraries.values.where(isUserLibrary);
     // Sum total size of scripts in each referenced library.
     int nonPlatformSize = 0;
     for (LibraryElement lib in referencedLibraries) {
       for (CompilationUnitElement compilationUnit in lib.compilationUnits) {
         nonPlatformSize += compilationUnit.script.text.length;
       }
     }
     int percentage = compiler.assembledCode.length * 100 ~/ nonPlatformSize;
     log('Total used non-platform files size: ${nonPlatformSize} bytes, '
         'bundle size: ${compiler.assembledCode.length} bytes (${percentage}%)');
   }
 
   log(String message) => compiler.log('[DartBackend] $message');
 
+  void onLibraryLoaded(LibraryElement library, Uri uri) {
+    if (useMirrorHelperLibrary && library == compiler.mirrorsLibrary) {
+      compiler.mirrorHelperLibrary = compiler.scanBuiltinLibrary(
+          MirrorRenamer.MIRROR_HELPER_LIBRARY_NAME);
+      compiler.mirrorHelperFunction = compiler.mirrorHelperLibrary.find(
+          const SourceString(MirrorRenamer.MIRROR_HELPER_GET_NAME_FUNCTION));
+    }
+  }
   void registerStaticSend(Element element, Node node) {

[ahe, 2013/08/19 15:34:06]

Add newline before this method.

[zarah, 2013/08/20 14:08:17]

Done.

-    if (useMirrorHelperLibrary && compiler.mirrorsLibrary != null) {
-      MirrorRenamer.handleStaticSend(renames, element, node, compiler);
+    if (useMirrorHelperLibrary) {
+      MirrorRenamer.registerStaticSend(element, node, compiler);
     }
   }
+
+  void registerHelperFunction(Element element, Node node) {
+    if (element.getLibrary() == compiler.mirrorHelperLibrary) {
+      MirrorRenamer.registerHelperFunction(element, node, compiler);
+    }
+  }
+
+  void registerStaticUse(Element element, Enqueuer enqueuer) {
+    if (useMirrorHelperLibrary &&
+        element == compiler.mirrorSystemGetNameFunction) {
+      enqueuer.addToWorkList(compiler.mirrorHelperFunction);
+      }

[ahe, 2013/08/19 15:34:06]

Indentation.

[zarah, 2013/08/20 14:08:17]

Done.

+  }
 }
 
 class EmitterUnparser extends Unparser {
   final Map<Node, String> renames;
 
   EmitterUnparser(this.renames);
 
   visit(Node node) {
     if (node != null && renames.containsKey(node)) {
       sb.write(renames[node]);
@@ skipping 65 matching lines @@
 }
 
 compareElements(e0, e1) {
   int result = compareBy((e) => e.getLibrary().canonicalUri.toString())(e0, e1);
   if (result != 0) return result;
   return compareBy((e) => e.position().charOffset)(e0, e1);
 }
 
 List<Element> sortElements(Iterable<Element> elements) =>
     sorted(elements, compareElements);