Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2279093002:
[MD settings] layout sub-page search (Closed)
|
Created:
4 years, 3 months ago by dschuyler Modified:
4 years, 3 months ago Reviewers:
hcarmona CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] layout sub-page search
This CL changes the layout of the search input within a sub-page to more
closely match the updated mocks.
BUG=638453
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/6c52e7062d5fb7cd2a1cd888f2bdea797c95e40e
Cr-Commit-Position: refs/heads/master@{#414620}
Patch Set 1 : merge with master #
Messages
Total messages: 18 (13 generated)
Description was changed from ========== [MD settings] layout sub-page search This CL changes the layout of the search input within a sub-page to more closely match the updated mocks. BUG=638453 ========== to ========== [MD settings] layout sub-page search This CL changes the layout of the search input within a sub-page to more closely match the updated mocks. BUG=638453 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
dschuyler@chromium.org changed reviewers: + hcarmona@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] layout sub-page search This CL changes the layout of the search input within a sub-page to more closely match the updated mocks. BUG=638453 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] layout sub-page search This CL changes the layout of the search input within a sub-page to more closely match the updated mocks. BUG=638453 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/6c52e7062d5fb7cd2a1cd888f2bdea797c95e40e Cr-Commit-Position: refs/heads/master@{#414620} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6c52e7062d5fb7cd2a1cd888f2bdea797c95e40e Cr-Commit-Position: refs/heads/master@{#414620} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
