Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2279063002: Fix argument name in install_static::ReportingIsEnforcedByPolicy to be not-misleading (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix argument name in install_static::ReportingIsEnforcedByPolicy to be not-misleading The return value is whether it's enforced by policy, the out param is whether it's enabled (not whether it's enforced, which made it an awfully confusing name). R=ananta@chromium.org, jwd@chromium.org Committed: https://crrev.com/c062afd5b208ce6767978148ee84e99d01487309 Cr-Commit-Position: refs/heads/master@{#414712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M chrome/install_static/install_util.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/install_static/install_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
scottmg
4 years, 3 months ago (2016-08-25 21:21:26 UTC) #2
jwd
lgtm
4 years, 3 months ago (2016-08-25 21:24:03 UTC) #3
scottmg
+grt owners
4 years, 3 months ago (2016-08-25 21:28:04 UTC) #7
grt (UTC plus 2)
lgtm
4 years, 3 months ago (2016-08-26 09:36:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279063002/1
4 years, 3 months ago (2016-08-26 14:51:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 14:55:45 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 14:57:25 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c062afd5b208ce6767978148ee84e99d01487309
Cr-Commit-Position: refs/heads/master@{#414712}

Powered by Google App Engine
This is Rietveld 408576698