Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2279033004: SkOSFile instead of dirent in android font parser. (Closed)

Created:
4 years, 3 months ago by bungeman-skia
Modified:
4 years, 3 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkOSFile instead of dirent in android font parser. This makes the parser more portable while making essentially the same file system calls on Android. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2279033004 Committed: https://skia.googlesource.com/skia/+/22cffcace2ad526f55ba2579e65836d38f009d1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/ports/SkFontMgr_android_parser.cpp View 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
bungeman-skia
Much of the motivation here is to build and test these files unconditionally on all ...
4 years, 3 months ago (2016-08-25 21:48:08 UTC) #6
djsollen
lgtm
4 years, 3 months ago (2016-08-26 12:18:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279033004/1
4 years, 3 months ago (2016-08-26 14:14:56 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 14:15:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/22cffcace2ad526f55ba2579e65836d38f009d1a

Powered by Google App Engine
This is Rietveld 408576698