Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2279033002:
Regenerate the CNNIC whitelist. (Closed)
|
Created:
4 years, 3 months ago by davidben Modified:
4 years, 3 months ago Reviewers:
Ryan Sleevi CC:
chromium-reviews, cbentzel+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRegenerate the CNNIC whitelist.
More certificates have expired. This drops 110 entries or 3520 bytes
of binary size.
BUG=none
Committed: https://crrev.com/636130c3dce847da5c30fc618ddb905641c309d1
Cr-Commit-Position: refs/heads/master@{#414581}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by davidben@chromium.org to run a CQ dry run
davidben@chromium.org changed reviewers: + rsleevi@chromium.org
Certificates which fell off: https://drive.google.com/open?id=0B2ImyA6KAoPUMGFYMlNmbHhBRHM
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
3520kb? Surely you meant 3.5kb :) (32 bytes a hash * 110 hashes) Otherwise LGTM, just make sure to update description :)
Description was changed from ========== Regenerate the CNNIC whitelist. More certificates have expired. This drops 110 entries or 3520kb of binary size. BUG=none ========== to ========== Regenerate the CNNIC whitelist. More certificates have expired. This drops 110 entries or 3520 bytes of binary size. BUG=none ==========
On 2016/08/25 18:27:53, Ryan Sleevi (slow) wrote: > 3520kb? Surely you meant 3.5kb :) (32 bytes a hash * 110 hashes) > > Otherwise LGTM, just make sure to update description :) Er, yes, that one. Updated. :-)
The CQ bit was unchecked by davidben@chromium.org
The CQ bit was checked by davidben@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by davidben@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Regenerate the CNNIC whitelist. More certificates have expired. This drops 110 entries or 3520 bytes of binary size. BUG=none ========== to ========== Regenerate the CNNIC whitelist. More certificates have expired. This drops 110 entries or 3520 bytes of binary size. BUG=none ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Regenerate the CNNIC whitelist. More certificates have expired. This drops 110 entries or 3520 bytes of binary size. BUG=none ========== to ========== Regenerate the CNNIC whitelist. More certificates have expired. This drops 110 entries or 3520 bytes of binary size. BUG=none Committed: https://crrev.com/636130c3dce847da5c30fc618ddb905641c309d1 Cr-Commit-Position: refs/heads/master@{#414581} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/636130c3dce847da5c30fc618ddb905641c309d1 Cr-Commit-Position: refs/heads/master@{#414581} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
