Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 22790003: Make DataTransferItemList.add(data, type) arguments mandatory (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use, lgombos
Visibility:
Public.

Description

Make DataTransferItemList.add(data, type) arguments mandatory Make DataTransferItemList.add(data, type) arguments mandatory to match the specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#datatransferitemlist DataTransferItemList is not implemented in Firefox 23 or IE10. BUG=271424 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156025

Patch Set 1 #

Patch Set 2 : Check exception type #

Total comments: 1

Patch Set 3 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -71 lines) Patch
M LayoutTests/fast/events/drag-dataTransferItemList.html View 1 2 8 chunks +37 lines, -47 lines 0 comments Download
M LayoutTests/fast/events/drag-dataTransferItemList-expected.txt View 1 2 1 chunk +42 lines, -22 lines 0 comments Download
M Source/core/dom/DataTransferItemList.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-12 13:26:16 UTC) #1
do-not-use
https://codereview.chromium.org/22790003/diff/3001/LayoutTests/fast/events/drag-dataTransferItemList.html File LayoutTests/fast/events/drag-dataTransferItemList.html (right): https://codereview.chromium.org/22790003/diff/3001/LayoutTests/fast/events/drag-dataTransferItemList.html#newcode174 LayoutTests/fast/events/drag-dataTransferItemList.html:174: <div id="console"></div> Note that I added the console div ...
7 years, 4 months ago (2013-08-12 13:40:32 UTC) #2
arv (Not doing code reviews)
LGTM
7 years, 4 months ago (2013-08-12 15:00:08 UTC) #3
haraken
LGTM. Needs an approval from an API owner.
7 years, 4 months ago (2013-08-12 15:47:51 UTC) #4
do-not-use
+jochen
7 years, 4 months ago (2013-08-13 10:50:43 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-13 13:56:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22790003/10001
7 years, 4 months ago (2013-08-13 14:00:25 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 15:47:34 UTC) #8
Message was sent while issue was closed.
Change committed as 156025

Powered by Google App Engine
This is Rietveld 408576698