Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2278963002: Fully setup the catch variable for catch scopes (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
Reviewers:
Toon Verwaest, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fully setup the catch variable for catch scopes If the parser creates a catch scope, the variable is also added to ordered_variables_ so just always do that. Otherwise, it's not possible to create a ScopeInfo for that catch scope R=verwaest@chromium.org BUG= Committed: https://crrev.com/1937d90085013ce5441bfdd346eaa6c32a2de027 Cr-Commit-Position: refs/heads/master@{#38921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/ast/scopes.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-08-25 12:45:30 UTC) #1
jochen (gone - plz use gerrit)
+adamk
4 years, 3 months ago (2016-08-25 19:49:37 UTC) #7
Toon Verwaest
lgtm
4 years, 3 months ago (2016-08-25 20:21:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278963002/1
4 years, 3 months ago (2016-08-25 20:42:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 20:44:25 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 20:45:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1937d90085013ce5441bfdd346eaa6c32a2de027
Cr-Commit-Position: refs/heads/master@{#38921}

Powered by Google App Engine
This is Rietveld 408576698