Revert of Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument

Revert of Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument (patchset #4 id:60001 of https://codereview.chromium.org/2208073004/ )

Reason for revert:
Reverting since http/tests/images/png-partial-load-as-document.html consistently leaks on WebKit Linux Leak and LeakExpectations says "Sheriff is expected to revert culprit CLs instead of suppressing the leaks"

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fimages%2Fpng-partial-load-as-document.html&testType=webkit_tests

Original issue's description:
> Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument
>
> Case 1: When a image is loaded as a subresource, loading is stared by
> ImageResource::fetch() in ImageLoader::doUpdateFromElement().
> Case 2: When a image is loaded as a main document, the start of the loading is
> emulated by setImage() in ImageLoader::updateFromElement() and
> ImageDocumentParser will do the subsequent loading steps.
>
> However in Case 2, |m_hasPendingLoadEvent| is set to false
> (in setImageWithoutConsideringPendingLoadEvent()), causing |imageStillLoading|
> to be false and ensureFallbackContent() to be called in
> HTMLImageElement::selectSourceURL(), and thus a box indicating a broken image
> is displayed during loading instead of the image displayed progressively.
> This is regression since https://codereview.chromium.org/1879793003.
>
> This CL makes the behavior of Case 1 and 2 consistent, by moving what is done
> in Case 1 to setImagePending(), and makes Case 1 and 2 both to call
> setImagePending().
>
> This CL also adds a layout test to confirm that an image is displayed
> progressively when loaded as a main document.
>
> BUG=632495
>
> Committed: https://crrev.com/576c7a048bfc30faf510eeda07f303fa9dd12898
> Cr-Commit-Position: refs/heads/master@{#414008}

TBR=japhet@chromium.org,yhirano@chromium.org,hiroshige@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=632495
Committed: https://crrev.com/8b3f5df1a65187e662fcf2fd5ead1ccb89226f31
Cr-Commit-Position: refs/heads/master@{#414441}

[johnme, 2016-08-25 12:32:23]

The CQ bit was checked by johnme@chromium.org

[johnme, 2016-08-25 12:32:24]

Created Revert of Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in
ImageDocument

[johnme, 2016-08-25 12:32:33]

The CQ bit was unchecked by johnme@chromium.org

[johnme, 2016-08-25 12:32:54]

Description was changed from

==========
Revert of Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in
ImageDocument (patchset #4 id:60001 of
https://codereview.chromium.org/2208073004/ )

Reason for revert:
Reverting since http/tests/images/png-partial-load-as-document.html consistently
leaks on WebKit Linux Leak and LeakExpectations says "Sheriff is expected to
revert culprit CLs instead of suppressing the leaks"

Original issue's description:
> Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument
> 
> Case 1: When a image is loaded as a subresource, loading is stared by
> ImageResource::fetch() in ImageLoader::doUpdateFromElement().
> Case 2: When a image is loaded as a main document, the start of the loading is
> emulated by setImage() in ImageLoader::updateFromElement() and
> ImageDocumentParser will do the subsequent loading steps.
> 
> However in Case 2, |m_hasPendingLoadEvent| is set to false
> (in setImageWithoutConsideringPendingLoadEvent()), causing |imageStillLoading|
> to be false and ensureFallbackContent() to be called in
> HTMLImageElement::selectSourceURL(), and thus a box indicating a broken image
> is displayed during loading instead of the image displayed progressively.
> This is regression since https://codereview.chromium.org/1879793003.
> 
> This CL makes the behavior of Case 1 and 2 consistent, by moving what is done
> in Case 1 to setImagePending(), and makes Case 1 and 2 both to call
> setImagePending().
> 
> This CL also adds a layout test to confirm that an image is displayed
> progressively when loaded as a main document.
> 
> BUG=632495
> 
> Committed: https://crrev.com/576c7a048bfc30faf510eeda07f303fa9dd12898
> Cr-Commit-Position: refs/heads/master@{#414008}

TBR=japhet@chromium.org,yhirano@chromium.org,hiroshige@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=632495
==========

to

==========
Revert of Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in
ImageDocument (patchset #4 id:60001 of
https://codereview.chromium.org/2208073004/ )

Reason for revert:
Reverting since http/tests/images/png-partial-load-as-document.html consistently
leaks on WebKit Linux Leak and LeakExpectations says "Sheriff is expected to
revert culprit CLs instead of suppressing the leaks"

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ht...

Original issue's description:
> Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument
> 
> Case 1: When a image is loaded as a subresource, loading is stared by
> ImageResource::fetch() in ImageLoader::doUpdateFromElement().
> Case 2: When a image is loaded as a main document, the start of the loading is
> emulated by setImage() in ImageLoader::updateFromElement() and
> ImageDocumentParser will do the subsequent loading steps.
> 
> However in Case 2, |m_hasPendingLoadEvent| is set to false
> (in setImageWithoutConsideringPendingLoadEvent()), causing |imageStillLoading|
> to be false and ensureFallbackContent() to be called in
> HTMLImageElement::selectSourceURL(), and thus a box indicating a broken image
> is displayed during loading instead of the image displayed progressively.
> This is regression since https://codereview.chromium.org/1879793003.
> 
> This CL makes the behavior of Case 1 and 2 consistent, by moving what is done
> in Case 1 to setImagePending(), and makes Case 1 and 2 both to call
> setImagePending().
> 
> This CL also adds a layout test to confirm that an image is displayed
> progressively when loaded as a main document.
> 
> BUG=632495
> 
> Committed: https://crrev.com/576c7a048bfc30faf510eeda07f303fa9dd12898
> Cr-Commit-Position: refs/heads/master@{#414008}

TBR=japhet@chromium.org,yhirano@chromium.org,hiroshige@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=632495
==========

[johnme, 2016-08-25 12:32:59]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2016-08-25 12:33:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-08-25 13:41:48]

On 2016/08/25 12:33:17, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

lgtm, thanks!

[johnme, 2016-08-25 15:25:33]

The CQ bit was unchecked by johnme@chromium.org

[johnme, 2016-08-25 15:25:47]

Description was changed from

==========
Revert of Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in
ImageDocument (patchset #4 id:60001 of
https://codereview.chromium.org/2208073004/ )

Reason for revert:
Reverting since http/tests/images/png-partial-load-as-document.html consistently
leaks on WebKit Linux Leak and LeakExpectations says "Sheriff is expected to
revert culprit CLs instead of suppressing the leaks"

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ht...

Original issue's description:
> Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument
> 
> Case 1: When a image is loaded as a subresource, loading is stared by
> ImageResource::fetch() in ImageLoader::doUpdateFromElement().
> Case 2: When a image is loaded as a main document, the start of the loading is
> emulated by setImage() in ImageLoader::updateFromElement() and
> ImageDocumentParser will do the subsequent loading steps.
> 
> However in Case 2, |m_hasPendingLoadEvent| is set to false
> (in setImageWithoutConsideringPendingLoadEvent()), causing |imageStillLoading|
> to be false and ensureFallbackContent() to be called in
> HTMLImageElement::selectSourceURL(), and thus a box indicating a broken image
> is displayed during loading instead of the image displayed progressively.
> This is regression since https://codereview.chromium.org/1879793003.
> 
> This CL makes the behavior of Case 1 and 2 consistent, by moving what is done
> in Case 1 to setImagePending(), and makes Case 1 and 2 both to call
> setImagePending().
> 
> This CL also adds a layout test to confirm that an image is displayed
> progressively when loaded as a main document.
> 
> BUG=632495
> 
> Committed: https://crrev.com/576c7a048bfc30faf510eeda07f303fa9dd12898
> Cr-Commit-Position: refs/heads/master@{#414008}

TBR=japhet@chromium.org,yhirano@chromium.org,hiroshige@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=632495
==========

to

==========
Revert of Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in
ImageDocument (patchset #4 id:60001 of
https://codereview.chromium.org/2208073004/ )

Reason for revert:
Reverting since http/tests/images/png-partial-load-as-document.html consistently
leaks on WebKit Linux Leak and LeakExpectations says "Sheriff is expected to
revert culprit CLs instead of suppressing the leaks"

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ht...

Original issue's description:
> Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument
> 
> Case 1: When a image is loaded as a subresource, loading is stared by
> ImageResource::fetch() in ImageLoader::doUpdateFromElement().
> Case 2: When a image is loaded as a main document, the start of the loading is
> emulated by setImage() in ImageLoader::updateFromElement() and
> ImageDocumentParser will do the subsequent loading steps.
> 
> However in Case 2, |m_hasPendingLoadEvent| is set to false
> (in setImageWithoutConsideringPendingLoadEvent()), causing |imageStillLoading|
> to be false and ensureFallbackContent() to be called in
> HTMLImageElement::selectSourceURL(), and thus a box indicating a broken image
> is displayed during loading instead of the image displayed progressively.
> This is regression since https://codereview.chromium.org/1879793003.
> 
> This CL makes the behavior of Case 1 and 2 consistent, by moving what is done
> in Case 1 to setImagePending(), and makes Case 1 and 2 both to call
> setImagePending().
> 
> This CL also adds a layout test to confirm that an image is displayed
> progressively when loaded as a main document.
> 
> BUG=632495
> 
> Committed: https://crrev.com/576c7a048bfc30faf510eeda07f303fa9dd12898
> Cr-Commit-Position: refs/heads/master@{#414008}

TBR=japhet@chromium.org,yhirano@chromium.org,hiroshige@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=632495
==========

[johnme, 2016-08-25 15:25:53]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2016-08-25 15:26:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 15:30:39]

Description was changed from

==========
Revert of Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in
ImageDocument (patchset #4 id:60001 of
https://codereview.chromium.org/2208073004/ )

Reason for revert:
Reverting since http/tests/images/png-partial-load-as-document.html consistently
leaks on WebKit Linux Leak and LeakExpectations says "Sheriff is expected to
revert culprit CLs instead of suppressing the leaks"

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ht...

Original issue's description:
> Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument
> 
> Case 1: When a image is loaded as a subresource, loading is stared by
> ImageResource::fetch() in ImageLoader::doUpdateFromElement().
> Case 2: When a image is loaded as a main document, the start of the loading is
> emulated by setImage() in ImageLoader::updateFromElement() and
> ImageDocumentParser will do the subsequent loading steps.
> 
> However in Case 2, |m_hasPendingLoadEvent| is set to false
> (in setImageWithoutConsideringPendingLoadEvent()), causing |imageStillLoading|
> to be false and ensureFallbackContent() to be called in
> HTMLImageElement::selectSourceURL(), and thus a box indicating a broken image
> is displayed during loading instead of the image displayed progressively.
> This is regression since https://codereview.chromium.org/1879793003.
> 
> This CL makes the behavior of Case 1 and 2 consistent, by moving what is done
> in Case 1 to setImagePending(), and makes Case 1 and 2 both to call
> setImagePending().
> 
> This CL also adds a layout test to confirm that an image is displayed
> progressively when loaded as a main document.
> 
> BUG=632495
> 
> Committed: https://crrev.com/576c7a048bfc30faf510eeda07f303fa9dd12898
> Cr-Commit-Position: refs/heads/master@{#414008}

TBR=japhet@chromium.org,yhirano@chromium.org,hiroshige@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=632495
==========

to

==========
Revert of Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in
ImageDocument (patchset #4 id:60001 of
https://codereview.chromium.org/2208073004/ )

Reason for revert:
Reverting since http/tests/images/png-partial-load-as-document.html consistently
leaks on WebKit Linux Leak and LeakExpectations says "Sheriff is expected to
revert culprit CLs instead of suppressing the leaks"

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ht...

Original issue's description:
> Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument
> 
> Case 1: When a image is loaded as a subresource, loading is stared by
> ImageResource::fetch() in ImageLoader::doUpdateFromElement().
> Case 2: When a image is loaded as a main document, the start of the loading is
> emulated by setImage() in ImageLoader::updateFromElement() and
> ImageDocumentParser will do the subsequent loading steps.
> 
> However in Case 2, |m_hasPendingLoadEvent| is set to false
> (in setImageWithoutConsideringPendingLoadEvent()), causing |imageStillLoading|
> to be false and ensureFallbackContent() to be called in
> HTMLImageElement::selectSourceURL(), and thus a box indicating a broken image
> is displayed during loading instead of the image displayed progressively.
> This is regression since https://codereview.chromium.org/1879793003.
> 
> This CL makes the behavior of Case 1 and 2 consistent, by moving what is done
> in Case 1 to setImagePending(), and makes Case 1 and 2 both to call
> setImagePending().
> 
> This CL also adds a layout test to confirm that an image is displayed
> progressively when loaded as a main document.
> 
> BUG=632495
> 
> Committed: https://crrev.com/576c7a048bfc30faf510eeda07f303fa9dd12898
> Cr-Commit-Position: refs/heads/master@{#414008}

TBR=japhet@chromium.org,yhirano@chromium.org,hiroshige@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=632495
==========

[commit-bot: I haz the power, 2016-08-25 15:30:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-25 15:33:00]

Description was changed from

==========
Revert of Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in
ImageDocument (patchset #4 id:60001 of
https://codereview.chromium.org/2208073004/ )

Reason for revert:
Reverting since http/tests/images/png-partial-load-as-document.html consistently
leaks on WebKit Linux Leak and LeakExpectations says "Sheriff is expected to
revert culprit CLs instead of suppressing the leaks"

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ht...

Original issue's description:
> Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument
> 
> Case 1: When a image is loaded as a subresource, loading is stared by
> ImageResource::fetch() in ImageLoader::doUpdateFromElement().
> Case 2: When a image is loaded as a main document, the start of the loading is
> emulated by setImage() in ImageLoader::updateFromElement() and
> ImageDocumentParser will do the subsequent loading steps.
> 
> However in Case 2, |m_hasPendingLoadEvent| is set to false
> (in setImageWithoutConsideringPendingLoadEvent()), causing |imageStillLoading|
> to be false and ensureFallbackContent() to be called in
> HTMLImageElement::selectSourceURL(), and thus a box indicating a broken image
> is displayed during loading instead of the image displayed progressively.
> This is regression since https://codereview.chromium.org/1879793003.
> 
> This CL makes the behavior of Case 1 and 2 consistent, by moving what is done
> in Case 1 to setImagePending(), and makes Case 1 and 2 both to call
> setImagePending().
> 
> This CL also adds a layout test to confirm that an image is displayed
> progressively when loaded as a main document.
> 
> BUG=632495
> 
> Committed: https://crrev.com/576c7a048bfc30faf510eeda07f303fa9dd12898
> Cr-Commit-Position: refs/heads/master@{#414008}

TBR=japhet@chromium.org,yhirano@chromium.org,hiroshige@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=632495
==========

to

==========
Revert of Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in
ImageDocument (patchset #4 id:60001 of
https://codereview.chromium.org/2208073004/ )

Reason for revert:
Reverting since http/tests/images/png-partial-load-as-document.html consistently
leaks on WebKit Linux Leak and LeakExpectations says "Sheriff is expected to
revert culprit CLs instead of suppressing the leaks"

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ht...

Original issue's description:
> Fix ImageLoader::m_hasPendingLoadEvent/m_imageComplete in ImageDocument
>
> Case 1: When a image is loaded as a subresource, loading is stared by
> ImageResource::fetch() in ImageLoader::doUpdateFromElement().
> Case 2: When a image is loaded as a main document, the start of the loading is
> emulated by setImage() in ImageLoader::updateFromElement() and
> ImageDocumentParser will do the subsequent loading steps.
>
> However in Case 2, |m_hasPendingLoadEvent| is set to false
> (in setImageWithoutConsideringPendingLoadEvent()), causing |imageStillLoading|
> to be false and ensureFallbackContent() to be called in
> HTMLImageElement::selectSourceURL(), and thus a box indicating a broken image
> is displayed during loading instead of the image displayed progressively.
> This is regression since https://codereview.chromium.org/1879793003.
>
> This CL makes the behavior of Case 1 and 2 consistent, by moving what is done
> in Case 1 to setImagePending(), and makes Case 1 and 2 both to call
> setImagePending().
>
> This CL also adds a layout test to confirm that an image is displayed
> progressively when loaded as a main document.
>
> BUG=632495
>
> Committed: https://crrev.com/576c7a048bfc30faf510eeda07f303fa9dd12898
> Cr-Commit-Position: refs/heads/master@{#414008}

TBR=japhet@chromium.org,yhirano@chromium.org,hiroshige@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=632495

Committed: https://crrev.com/8b3f5df1a65187e662fcf2fd5ead1ccb89226f31
Cr-Commit-Position: refs/heads/master@{#414441}
==========

[commit-bot: I haz the power, 2016-08-25 15:33:01]

Patchset 1 (id:??) landed as
https://crrev.com/8b3f5df1a65187e662fcf2fd5ead1ccb89226f31
Cr-Commit-Position: refs/heads/master@{#414441}

[haraken, 2016-08-26 00:53:06]

LGTM