Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2278933002: Don't create a handle scope when finalizing the bytecode (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't create a handle scope when finalizing the bytecode During finalization, we create SharedFunctionInfos which in turn will create ScopeInfos for the Scopes in the AST. The Scopes then cache a handle to the ScopeInfos. However, once the scope is closed, all those handles get zapped, and it's no longer possible to access the scopes (even though we actually still need the AST). R=rmcilroy@chromium.org BUG= Committed: https://crrev.com/6c744a97151f4b55c0f401b397761a87030c8494 Cr-Commit-Position: refs/heads/master@{#38898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-08-25 10:54:47 UTC) #1
rmcilroy
This was to avoid a performance regression that introducing CanonicalHandleScopes gave us, but didn't fully ...
4 years, 3 months ago (2016-08-25 11:00:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278933002/1
4 years, 3 months ago (2016-08-25 11:02:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 11:15:40 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 11:16:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c744a97151f4b55c0f401b397761a87030c8494
Cr-Commit-Position: refs/heads/master@{#38898}

Powered by Google App Engine
This is Rietveld 408576698