[ash-md] Keeps overview mode shield above DesktopBackgroundView

[ash-md] Keeps overview mode shield above DesktopBackgroundView

Reparenting the background widgets modifies the stacking order. This CL
restores the intended order by updating the stacking in Layout().

BUG=640929
Committed: https://crrev.com/6fae847c2b1a45bc248e33bf29db361dd13fcf47
Cr-Commit-Position: refs/heads/master@{#414537}

[varkha, 2016-08-25 17:57:07]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 17:58:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-08-25 18:00:39]

varkha@chromium.org changed reviewers:
+ jamescook@chromium.org

[varkha, 2016-08-25 18:00:40]

jamescook@, can you please take a look? Thanks!
We update the wallpaper asynchronously and so the bounds update in overview mode
handlers did not work (otherwise my preference would be to maintain the overview
shield being on top there. So I keep the DesktopBackgroundView at the bottom
instead.

[James Cook, 2016-08-25 18:32:12]

Can you ask bshe, achuith, or msw to take a look at this? I'm not very familiar
with this code. I know we've also had bugs in the past related to wallpaper
stacking (like the desktop background moves around during screen lock).

https://codereview.chromium.org/2278903003/diff/1/ash/common/wm/overview/wind...
File ash/common/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2278903003/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_grid.cc:856:
widget_window->SetName("overview-mode-shield");
nit: I usually use OverviewModeShield for these names

Thanks for adding a name. Life is much easier when all widgets have names.

https://codereview.chromium.org/2278903003/diff/1/ash/desktop_background/desk...
File ash/desktop_background/desktop_background_view.cc (right):

https://codereview.chromium.org/2278903003/diff/1/ash/desktop_background/desk...
ash/desktop_background/desktop_background_view.cc:45: // background view such as
an overivew mode shield.
nit: overview

[varkha, 2016-08-25 19:22:15]

varkha@chromium.org changed reviewers:
+ bshe@chromium.org

[varkha, 2016-08-25 19:22:15]

bshe@, can you see please if this makes sense? I am not aware of anything that
needs the background view to be anywhere other than at the bottom of its
container.

[varkha, 2016-08-25 19:55:41]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[varkha, 2016-08-25 19:56:42]

https://codereview.chromium.org/2278903003/diff/1/ash/common/wm/overview/wind...
File ash/common/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2278903003/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_grid.cc:856:
widget_window->SetName("overview-mode-shield");
On 2016/08/25 18:32:12, James Cook wrote:
> nit: I usually use OverviewModeShield for these names
> 
> Thanks for adding a name. Life is much easier when all widgets have names.

Done. Here and for other overview mode widgets.

https://codereview.chromium.org/2278903003/diff/1/ash/desktop_background/desk...
File ash/desktop_background/desktop_background_view.cc (right):

https://codereview.chromium.org/2278903003/diff/1/ash/desktop_background/desk...
ash/desktop_background/desktop_background_view.cc:45: // background view such as
an overivew mode shield.
On 2016/08/25 18:32:12, James Cook wrote:
> nit: overview

Done.

[commit-bot: I haz the power, 2016-08-25 19:56:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bshe, 2016-08-25 20:29:56]

On 2016/08/25 19:56:42, varkha wrote:
>
https://codereview.chromium.org/2278903003/diff/1/ash/common/wm/overview/wind...
> File ash/common/wm/overview/window_grid.cc (right):
> 
>
https://codereview.chromium.org/2278903003/diff/1/ash/common/wm/overview/wind...
> ash/common/wm/overview/window_grid.cc:856:
> widget_window->SetName("overview-mode-shield");
> On 2016/08/25 18:32:12, James Cook wrote:
> > nit: I usually use OverviewModeShield for these names
> > 
> > Thanks for adding a name. Life is much easier when all widgets have names.
> 
> Done. Here and for other overview mode widgets.
> 
>
https://codereview.chromium.org/2278903003/diff/1/ash/desktop_background/desk...
> File ash/desktop_background/desktop_background_view.cc (right):
> 
>
https://codereview.chromium.org/2278903003/diff/1/ash/desktop_background/desk...
> ash/desktop_background/desktop_background_view.cc:45: // background view such
as
> an overivew mode shield.
> On 2016/08/25 18:32:12, James Cook wrote:
> > nit: overview
> 
> Done.

lgtm. It looks safe for both DesktopBackgroundContainer and LockScreenContainer.

[commit-bot: I haz the power, 2016-08-25 20:51:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 20:51:40]

Dry run: This issue passed the CQ dry run.

[varkha, 2016-08-25 21:00:43]

The CQ bit was checked by varkha@chromium.org

[commit-bot: I haz the power, 2016-08-25 21:01:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 21:09:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 21:12:45]

Description was changed from

==========
[ash-md] Keeps overview mode shield above DesktopBackgroundView

Reparenting the background widgets modifies the stacking order. This CL
restores the intended order by updating the stacking in Layout().

BUG=640929
==========

to

==========
[ash-md] Keeps overview mode shield above DesktopBackgroundView

Reparenting the background widgets modifies the stacking order. This CL
restores the intended order by updating the stacking in Layout().

BUG=640929

Committed: https://crrev.com/6fae847c2b1a45bc248e33bf29db361dd13fcf47
Cr-Commit-Position: refs/heads/master@{#414537}
==========

[commit-bot: I haz the power, 2016-08-25 21:12:46]

Patchset 2 (id:??) landed as
https://crrev.com/6fae847c2b1a45bc248e33bf29db361dd13fcf47
Cr-Commit-Position: refs/heads/master@{#414537}