Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2278903002: [turbofan] Narrow type of Phis during JSTypedLowering. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Narrow type of Phis during JSTypedLowering. Try to narrow types of Phis further during JSTypedLowering, because lowering based on types might create further opportunities for improving the types. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/0da5b8222b623e5c975e4552ce7cd42cbe56ec1a Cr-Commit-Position: refs/heads/master@{#38895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-25 09:06:39 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the narrowing for Phis. Helps NavierStokes quite a bit (due to the ...
4 years, 3 months ago (2016-08-25 09:07:31 UTC) #4
Jarin
lgtm
4 years, 3 months ago (2016-08-25 09:12:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278903002/1
4 years, 3 months ago (2016-08-25 09:13:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 09:36:20 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 09:36:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0da5b8222b623e5c975e4552ce7cd42cbe56ec1a
Cr-Commit-Position: refs/heads/master@{#38895}

Powered by Google App Engine
This is Rietveld 408576698