Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2278883003: Remove calls to deprecated MessageLoop methods from sandbox/. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods from sandbox/. This CL removes calls to these methods from sandbox/ files: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::ReleaseSoon - MessageLoop::DeleteSoon - MessageLoop::Run - MessageLoop::RunUntilIdle BUG=616447 Committed: https://crrev.com/02837149eb615d36c22c4191ec6882fe3b018393 Cr-Commit-Position: refs/heads/master@{#415979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
fdoray
PTAL
4 years, 3 months ago (2016-08-26 12:59:34 UTC) #3
fdoray
Could a sandbox/ owner review this CL? Thanks.
4 years, 3 months ago (2016-09-01 16:16:29 UTC) #5
jln (very slow on Chromium)
lgtm, thanks
4 years, 3 months ago (2016-09-01 16:18:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278883003/1
4 years, 3 months ago (2016-09-01 16:22:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 17:03:40 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 17:05:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02837149eb615d36c22c4191ec6882fe3b018393
Cr-Commit-Position: refs/heads/master@{#415979}

Powered by Google App Engine
This is Rietveld 408576698