Stop supporting legacy keywords in Referrer-Policy header

Stop supporting legacy keywords in Referrer-Policy header

https://github.com/w3c/webappsec-referrer-policy/pull/66 removed support
for legacy keywords in the Referrer-Policy header. There is no need to
support these legacy keywords because the Referrer-Policy header is
brand new (not shipped yet) and there is no legacy usage.

In the course of implementing this, I realized that we do in fact
support legacy keywords for 'referrerpolicy' content attributes. This is
not necessary per the spec, but I left it as-is since we should measure
usage before removing support for legacy keywords in 'referrerpolicy'
attributes.

BUG=641128
Committed: https://crrev.com/9517b0e7af83a9c482e1a02dd8c31d146caf9b37
Cr-Commit-Position: refs/heads/master@{#414903}

[estark, 2016-08-25 22:37:32]

Patchset #1 (id:1) has been deleted

[estark, 2016-08-25 22:38:30]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 22:39:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-08-25 22:40:24]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 22:40:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-08-25 22:40:44]

estark@chromium.org changed reviewers:
+ jochen@chromium.org, mmenke@chromium.org

[estark, 2016-08-25 22:40:44]

mmenke: can you please review net/url_request?
jochen: can you please review the Blink changes?
Thanks!

[estark, 2016-08-25 22:41:12]

Description was changed from

==========
Stop support legacy keywords in Referrer-Policy header

https://github.com/w3c/webappsec-referrer-policy/pull/66 removed support
for legacy keywords in the Referrer-Policy header. There is no need to
support these legacy keywords because the Referrer-Policy header is
brand new (not shipped yet) and there is no legacy usage.

In the course of implementing this, I realized that we do in fact
support legacy keywords for 'referrerpolicy' content attributes. This is
not necessary per the spec, but I left it as-is since we should measure
usage before removing support for legacy keywords in 'referrerpolicy'
attributes.

BUG=641128
==========

to

==========
Stop supporting legacy keywords in Referrer-Policy header

https://github.com/w3c/webappsec-referrer-policy/pull/66 removed support
for legacy keywords in the Referrer-Policy header. There is no need to
support these legacy keywords because the Referrer-Policy header is
brand new (not shipped yet) and there is no legacy usage.

In the course of implementing this, I realized that we do in fact
support legacy keywords for 'referrerpolicy' content attributes. This is
not necessary per the spec, but I left it as-is since we should measure
usage before removing support for legacy keywords in 'referrerpolicy'
attributes.

BUG=641128
==========

[mmenke, 2016-08-25 22:43:13]

On 2016/08/25 22:40:44, estark wrote:
> mmenke: can you please review net/url_request?
> jochen: can you please review the Blink changes?
> Thanks!

net/ LGTM

[commit-bot: I haz the power, 2016-08-26 03:11:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 03:11:42]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-08-26 15:07:35]

lgtm with nit

https://codereview.chromium.org/2278823004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp (right):

https://codereview.chromium.org/2278823004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp:61: static bool
referrerPolicyFromStringImpl(const String& policy, bool supportLegacyKeywords,
ReferrerPolicy* result)
nit. please use an enum (class) instead of a bool

[estark, 2016-08-26 16:23:44]

Thanks both.

https://codereview.chromium.org/2278823004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp (right):

https://codereview.chromium.org/2278823004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp:61: static bool
referrerPolicyFromStringImpl(const String& policy, bool supportLegacyKeywords,
ReferrerPolicy* result)
On 2016/08/26 15:07:35, jochen wrote:
> nit. please use an enum (class) instead of a bool

Done.

[estark, 2016-08-26 16:23:48]

The CQ bit was checked by estark@chromium.org

[estark, 2016-08-26 16:23:48]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2278823004/#ps60001
(title: "jochen comment")

[commit-bot: I haz the power, 2016-08-26 16:24:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 18:58:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 18:58:53]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[estark, 2016-08-27 00:55:08]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-08-27 00:55:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 10:50:06]

Description was changed from

==========
Stop supporting legacy keywords in Referrer-Policy header

https://github.com/w3c/webappsec-referrer-policy/pull/66 removed support
for legacy keywords in the Referrer-Policy header. There is no need to
support these legacy keywords because the Referrer-Policy header is
brand new (not shipped yet) and there is no legacy usage.

In the course of implementing this, I realized that we do in fact
support legacy keywords for 'referrerpolicy' content attributes. This is
not necessary per the spec, but I left it as-is since we should measure
usage before removing support for legacy keywords in 'referrerpolicy'
attributes.

BUG=641128
==========

to

==========
Stop supporting legacy keywords in Referrer-Policy header

https://github.com/w3c/webappsec-referrer-policy/pull/66 removed support
for legacy keywords in the Referrer-Policy header. There is no need to
support these legacy keywords because the Referrer-Policy header is
brand new (not shipped yet) and there is no legacy usage.

In the course of implementing this, I realized that we do in fact
support legacy keywords for 'referrerpolicy' content attributes. This is
not necessary per the spec, but I left it as-is since we should measure
usage before removing support for legacy keywords in 'referrerpolicy'
attributes.

BUG=641128
==========

[commit-bot: I haz the power, 2016-08-27 10:50:07]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-27 10:52:09]

Description was changed from

==========
Stop supporting legacy keywords in Referrer-Policy header

https://github.com/w3c/webappsec-referrer-policy/pull/66 removed support
for legacy keywords in the Referrer-Policy header. There is no need to
support these legacy keywords because the Referrer-Policy header is
brand new (not shipped yet) and there is no legacy usage.

In the course of implementing this, I realized that we do in fact
support legacy keywords for 'referrerpolicy' content attributes. This is
not necessary per the spec, but I left it as-is since we should measure
usage before removing support for legacy keywords in 'referrerpolicy'
attributes.

BUG=641128
==========

to

==========
Stop supporting legacy keywords in Referrer-Policy header

https://github.com/w3c/webappsec-referrer-policy/pull/66 removed support
for legacy keywords in the Referrer-Policy header. There is no need to
support these legacy keywords because the Referrer-Policy header is
brand new (not shipped yet) and there is no legacy usage.

In the course of implementing this, I realized that we do in fact
support legacy keywords for 'referrerpolicy' content attributes. This is
not necessary per the spec, but I left it as-is since we should measure
usage before removing support for legacy keywords in 'referrerpolicy'
attributes.

BUG=641128

Committed: https://crrev.com/9517b0e7af83a9c482e1a02dd8c31d146caf9b37
Cr-Commit-Position: refs/heads/master@{#414903}
==========

[commit-bot: I haz the power, 2016-08-27 10:52:10]

Patchset 3 (id:??) landed as
https://crrev.com/9517b0e7af83a9c482e1a02dd8c31d146caf9b37
Cr-Commit-Position: refs/heads/master@{#414903}