Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2278803003: exo: Disable RGBX fullscreen overlays. (Closed)

Created:
4 years, 3 months ago by Daniele Castagna
Modified:
4 years, 3 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Disable RGBX fullscreen overlays. Fullscreen overlays have been enabled on minnie. Unfortunately there are some issues in HardwareDisplayPlaneManager:: AssignOverlayPlanes with RGBX buffers. This patch disables the overlay optimization for those buffers while we work on a fix. BUG=b/29430506 Committed: https://crrev.com/18d1778af83ec9877cdf33401eddf4b082f766ef Cr-Commit-Position: refs/heads/master@{#414281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/exo/display.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Daniele Castagna
4 years, 3 months ago (2016-08-25 02:06:45 UTC) #5
reveman
lgtm
4 years, 3 months ago (2016-08-25 02:16:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278803003/1
4 years, 3 months ago (2016-08-25 03:03:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 03:08:38 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/18d1778af83ec9877cdf33401eddf4b082f766ef Cr-Commit-Position: refs/heads/master@{#414281}
4 years, 3 months ago (2016-08-25 03:10:25 UTC) #13
Daniele Castagna
4 years, 3 months ago (2016-08-26 22:23:43 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2287773002/ by dcastagna@chromium.org.

The reason for reverting is: crrev.com/2281033003 makes it so the compositor
sends only one plane to Ozone.

In this way Ozone will accept an RGBX fullscreen plane..

Powered by Google App Engine
This is Rietveld 408576698