Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 2278803002: Use AnalyzedStyleUpdate for non-blocking sheets. (Closed)

Created:
4 years, 4 months ago by rune
Modified:
4 years, 3 months ago
Reviewers:
sashab
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use AnalyzedStyleUpdate for non-blocking sheets. For no apparent reason we were always doing a full document recalc when finishing loading a non-blocking stylesheet. From webkit: https://bugs.webkit.org/show_bug.cgi?id=119236 BUG=284142 Committed: https://crrev.com/5b71fe7f8ba2c184108d9fe41d80c2b9668f89c4 Cr-Commit-Position: refs/heads/master@{#414682}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Removed old test #

Total comments: 3

Patch Set 4 : Removed blank line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -24 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/add-non-blocking-sheet-recalc.html View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/link-alternate-style-recalc.html View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/link-alternate-style-recalc-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (16 generated)
sashab
Haha, nice find. It looks like fast/css/link-alternate-style-recalc is actaully testing exactly what you're fixing, so ...
4 years, 3 months ago (2016-08-25 02:53:45 UTC) #6
rune
On 2016/08/25 02:53:45, sashab wrote: > Haha, nice find. It looks like fast/css/link-alternate-style-recalc is actaully ...
4 years, 3 months ago (2016-08-25 11:15:06 UTC) #9
sashab
lgtm https://codereview.chromium.org/2278803002/diff/40001/third_party/WebKit/LayoutTests/fast/css/add-non-blocking-sheet-recalc.html File third_party/WebKit/LayoutTests/fast/css/add-non-blocking-sheet-recalc.html (right): https://codereview.chromium.org/2278803002/diff/40001/third_party/WebKit/LayoutTests/fast/css/add-non-blocking-sheet-recalc.html#newcode10 third_party/WebKit/LayoutTests/fast/css/add-non-blocking-sheet-recalc.html:10: Remove blank line https://codereview.chromium.org/2278803002/diff/40001/third_party/WebKit/LayoutTests/fast/css/add-non-blocking-sheet-recalc.html#newcode10 third_party/WebKit/LayoutTests/fast/css/add-non-blocking-sheet-recalc.html:10: Remove blank line
4 years, 3 months ago (2016-08-25 23:25:13 UTC) #16
rune
https://codereview.chromium.org/2278803002/diff/40001/third_party/WebKit/LayoutTests/fast/css/add-non-blocking-sheet-recalc.html File third_party/WebKit/LayoutTests/fast/css/add-non-blocking-sheet-recalc.html (right): https://codereview.chromium.org/2278803002/diff/40001/third_party/WebKit/LayoutTests/fast/css/add-non-blocking-sheet-recalc.html#newcode10 third_party/WebKit/LayoutTests/fast/css/add-non-blocking-sheet-recalc.html:10: On 2016/08/25 23:25:12, sashab wrote: > Remove blank line ...
4 years, 3 months ago (2016-08-26 07:15:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278803002/60001
4 years, 3 months ago (2016-08-26 07:16:01 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-26 10:49:57 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 10:52:07 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5b71fe7f8ba2c184108d9fe41d80c2b9668f89c4
Cr-Commit-Position: refs/heads/master@{#414682}

Powered by Google App Engine
This is Rietveld 408576698