Report the wasted network bytes when resource prefetches hit max limit

Report the wasted network bytes when resource prefetches hit max limit

BUG=625270
Committed: https://crrev.com/a30b7788400d638152f4727173e44a5b362903a2
Cr-Commit-Position: refs/heads/master@{#418646}

[Raj, 2016-08-24 22:48:32]

Description was changed from

==========
Report the wasted network bytes when resource prefetches hit max limit

BUG=625270
==========

to

==========
Report the wasted network bytes when resource prefetches hit max limit

BUG=625270
==========

[Raj, 2016-08-24 22:48:32]

rajendrant@chromium.org changed reviewers:
+ bengr@chromium.org

[bengr, 2016-08-26 17:15:44]

lgtm with nit.

https://codereview.chromium.org/2278793002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2278793002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:44600: +    resource prefetch. Logged
when a partially downloaded resource prefetch gets
prefetch -> precache fetch

[Raj, 2016-08-30 19:39:38]

rajendrant@chromium.org changed reviewers:
+ holte@chromium.org

[Raj, 2016-08-30 19:39:39]

holte: ptal

[Steven Holte, 2016-08-30 22:33:26]

https://codereview.chromium.org/2278793002/diff/40001/components/precache/cor...
File components/precache/core/precache_fetcher.cc (right):

https://codereview.chromium.org/2278793002/diff/40001/components/precache/cor...
components/precache/core/precache_fetcher.cc:284: network_response_bytes_, 1,
kMaxResponseBytes,
You probably shouldn't use kMaxResponseBytes here, since you shouldn't change
the bucket sizes later.  Suggest inlining the constant, or possibly using a
different value if you might adjust this one.

[Raj, 2016-09-14 00:14:36]

https://codereview.chromium.org/2278793002/diff/40001/components/precache/cor...
File components/precache/core/precache_fetcher.cc (right):

https://codereview.chromium.org/2278793002/diff/40001/components/precache/cor...
components/precache/core/precache_fetcher.cc:284: network_response_bytes_, 1,
kMaxResponseBytes,
On 2016/08/30 22:33:26, Steven Holte wrote:
> You probably shouldn't use kMaxResponseBytes here, since you shouldn't change
> the bucket sizes later.  Suggest inlining the constant, or possibly using a
> different value if you might adjust this one.

Done.

[Steven Holte, 2016-09-14 18:43:57]

LGTM, but either fix constant or comment.

https://codereview.chromium.org/2278793002/diff/60001/components/precache/cor...
File components/precache/core/precache_fetcher.cc (right):

https://codereview.chromium.org/2278793002/diff/60001/components/precache/cor...
components/precache/core/precache_fetcher.cc:285: 1024 * 1024 * 1024 /* 1 MB */,
100);
This is a 1 GiB not 1MB?

[Raj, 2016-09-14 18:51:20]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2016-09-14 18:51:21]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org,
holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2278793002/#ps80001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-09-14 18:52:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 19:54:45]

Description was changed from

==========
Report the wasted network bytes when resource prefetches hit max limit

BUG=625270
==========

to

==========
Report the wasted network bytes when resource prefetches hit max limit

BUG=625270
==========

[commit-bot: I haz the power, 2016-09-14 19:54:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-14 19:56:42]

Description was changed from

==========
Report the wasted network bytes when resource prefetches hit max limit

BUG=625270
==========

to

==========
Report the wasted network bytes when resource prefetches hit max limit

BUG=625270

Committed: https://crrev.com/a30b7788400d638152f4727173e44a5b362903a2
Cr-Commit-Position: refs/heads/master@{#418646}
==========

[commit-bot: I haz the power, 2016-09-14 19:56:44]

Patchset 5 (id:??) landed as
https://crrev.com/a30b7788400d638152f4727173e44a5b362903a2
Cr-Commit-Position: refs/heads/master@{#418646}