Modify RecentTabHelper to be always-on and observe the loading of the pages.

chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/recent_tab_helper.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/strings/string16.h"
+#include "base/test/scoped_feature_list.h"
 #include "base/test/test_mock_time_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
 #include "chrome/browser/android/offline_pages/test_offline_page_model_builder.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "components/offline_pages/offline_page_feature.h"
 #include "components/offline_pages/offline_page_item.h"
 #include "components/offline_pages/offline_page_model.h"
 #include "components/offline_pages/offline_page_test_archiver.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/web_contents.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace offline_pages {
 
@@ skipping 118 matching lines @@
     : recent_tab_helper_(nullptr),
       model_(nullptr),
       model_changed_count_(0),
       model_removed_count_(0),
       task_runner_(new base::TestMockTimeTaskRunner),
       weak_ptr_factory_(this) {
 }
 
 void RecentTabHelperTest::SetUp() {
   content::RenderViewHostTestHarness::SetUp();
+
   // Sets up the factory for testing.
   OfflinePageModelFactory::GetInstance()->SetTestingFactoryAndUse(
       browser_context(), BuildTestOfflinePageModel);
   RunUntilIdle();
 
   RecentTabHelper::CreateForWebContents(web_contents());
   recent_tab_helper_ =
       RecentTabHelper::FromWebContents(web_contents());
 
   recent_tab_helper_->SetDelegate(base::MakeUnique<TestDelegate>(
@@ skipping 33 matching lines @@
 void RecentTabHelperTest::FastForwardSnapshotController() {
   const size_t kLongDelayMs = 100*1000;
   task_runner_->FastForwardBy(base::TimeDelta::FromMilliseconds(kLongDelayMs));
 }
 
 TEST_F(RecentTabHelperTest, Basic) {
   EXPECT_NE(nullptr, recent_tab_helper());
 }
 
 TEST_F(RecentTabHelperTest, SimpleCapture) {
+  base::test::ScopedFeatureList scoped_feature_list;

[dewittj, 2016/08/24 23:01:40]

Can I suggest putting this as a member of RecentTabHelperTest, then only having
an inner feature list with no features enabled for the Basic and
FeatureNotEnabled tests?

[Dmitry Titov, 2016/08/25 00:36:09]

Done.

+  scoped_feature_list.InitAndEnableFeature(kOffliningRecentPagesFeature);
+
   NavigateAndCommit(kTestPageUrl);

[dewittj, 2016/08/24 23:01:39]

may want to separate navigate / commit phases to be able to test the state in
weird sequences.

[Dmitry Titov, 2016/08/25 00:36:09]

Not sure I have a good idea what exact navigate/commit sequences I would use
here. I only get DidFinishNavigate and filter for committed...

+  EXPECT_FALSE(recent_tab_helper()->is_page_ready_for_snapshot());
   recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
   RunUntilIdle();
+  EXPECT_TRUE(recent_tab_helper()->is_page_ready_for_snapshot());
   EXPECT_TRUE(model()->is_loaded());
   GetAllPages();
   EXPECT_EQ(1U, all_pages().size());
   EXPECT_EQ(kTestPageUrl, all_pages()[0].url);
 }
 
 TEST_F(RecentTabHelperTest, NoTabIdNoCapture) {
+  base::test::ScopedFeatureList scoped_feature_list;
+  scoped_feature_list.InitAndEnableFeature(kOffliningRecentPagesFeature);
+
   // Create delegate that returns 'false' as TabId retrieval result.
   recent_tab_helper()->SetDelegate(base::MakeUnique<TestDelegate>(
       this, task_runner(), kTabId, false));
 
   NavigateAndCommit(kTestPageUrl);
   recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
   RunUntilIdle();
   EXPECT_TRUE(model()->is_loaded());
   GetAllPages();
-  // No page shodul be captured.
+  // No page should be captured.
   EXPECT_EQ(0U, all_pages().size());
 }
 
 // Should end up with 1 page.
 TEST_F(RecentTabHelperTest, TwoCapturesSameUrl) {
+  base::test::ScopedFeatureList scoped_feature_list;
+  scoped_feature_list.InitAndEnableFeature(kOffliningRecentPagesFeature);
+
   NavigateAndCommit(kTestPageUrl);
   // Triggers snapshot after a time delay.
   recent_tab_helper()->DocumentAvailableInMainFrame();
   RunUntilIdle();
   EXPECT_TRUE(model()->is_loaded());
   EXPECT_EQ(0U, model_changed_count());
   // Move the snapshot controller's time forward so it gets past timeouts.
   FastForwardSnapshotController();
   RunUntilIdle();
   EXPECT_EQ(1U, model_changed_count());
   EXPECT_EQ(0U, model_removed_count());
   GetAllPages();
   EXPECT_EQ(1U, all_pages().size());
   EXPECT_EQ(kTestPageUrl, all_pages()[0].url);
 
   // Triggers snapshot immediately;
   recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
   RunUntilIdle();
   EXPECT_EQ(2U, model_changed_count());
   EXPECT_EQ(1U, model_removed_count());
   // the same page should be simply overridden.
   GetAllPages();
   EXPECT_EQ(1U, all_pages().size());
   EXPECT_EQ(kTestPageUrl, all_pages()[0].url);
 }
 
 // Should end up with 1 page.
 TEST_F(RecentTabHelperTest, TwoCapturesDifferentUrls) {
+  base::test::ScopedFeatureList scoped_feature_list;
+  scoped_feature_list.InitAndEnableFeature(kOffliningRecentPagesFeature);
+
   NavigateAndCommit(kTestPageUrl);
   // Triggers snapshot after a time delay.
   recent_tab_helper()->DocumentAvailableInMainFrame();
   RunUntilIdle();
   EXPECT_TRUE(model()->is_loaded());
   EXPECT_EQ(0U, model_changed_count());
   // Move the snapshot controller's time forward so it gets past timeouts.
   FastForwardSnapshotController();
   RunUntilIdle();
   EXPECT_EQ(1U, model_changed_count());
   EXPECT_EQ(0U, model_removed_count());
   GetAllPages();
   EXPECT_EQ(1U, all_pages().size());
   EXPECT_EQ(kTestPageUrl, all_pages()[0].url);
 
   NavigateAndCommit(kTestPageUrlOther);
   // Triggers snapshot immediately;
   recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
   RunUntilIdle();
   EXPECT_EQ(2U, model_changed_count());
   EXPECT_EQ(1U, model_removed_count());
   // the same page should be simply overridden.
   GetAllPages();
   EXPECT_EQ(1U, all_pages().size());
   EXPECT_EQ(kTestPageUrlOther, all_pages()[0].url);
 }
 
 TEST_F(RecentTabHelperTest, NoCaptureOnErrorPage) {
+  base::test::ScopedFeatureList scoped_feature_list;
+  scoped_feature_list.InitAndEnableFeature(kOffliningRecentPagesFeature);
+
   FailLoad(kTestPageUrl);
   recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
   RunUntilIdle();
   EXPECT_TRUE(model()->is_loaded());
   GetAllPages();
   EXPECT_EQ(0U, all_pages().size());
 }
 
+TEST_F(RecentTabHelperTest, FeatureNotEnabled) {
+  NavigateAndCommit(kTestPageUrl);
+  recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
+  RunUntilIdle();
+  EXPECT_TRUE(model()->is_loaded());
+  GetAllPages();
+  // No page should be captured.
+  EXPECT_EQ(0U, all_pages().size());
+}
+
 }  // namespace offline_pages