Modify RecentTabHelper to be always-on and observe the loading of the pages.

chrome/browser/android/offline_pages/recent_tab_helper.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_RECENT_TAB_HELPER_H_
 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_RECENT_TAB_HELPER_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 16 matching lines @@
 // oldest snapshot in the 'ring buffer'. As a result, there is always up to N
 // snapshots of recent pages on the device.
 class RecentTabHelper
     : public content::WebContentsObserver,
       public content::WebContentsUserData<RecentTabHelper>,
       public SnapshotController::Client {
  public:
   ~RecentTabHelper() override;
 
   // content::WebContentsObserver
+  void DidStartNavigation(
+      content::NavigationHandle* navigation_handle) override;
   void DidFinishNavigation(
       content::NavigationHandle* navigation_handle) override;
   void DocumentAvailableInMainFrame() override;
   void DocumentOnLoadCompletedInMainFrame() override;
 
   // SnapshotController::Client
   void StartSnapshot() override;
 
   // Delegate that is used by RecentTabHelper to get external dependencies.
   // Default implementation lives in .cc file, while tests provide an override.
   class Delegate {
    public:
     virtual ~Delegate() {}
     virtual std::unique_ptr<OfflinePageArchiver> CreatePageArchiver(
         content::WebContents* web_contents) = 0;
     virtual scoped_refptr<base::SingleThreadTaskRunner> GetTaskRunner() = 0;
     // There is no expectations that tab_id is always present.
     virtual bool GetTabId(content::WebContents* web_contents, int* tab_id) = 0;
   };
   void SetDelegate(std::unique_ptr<RecentTabHelper::Delegate> delegate);
 
+  bool is_page_ready_for_snapshot() const {
+    return is_page_ready_for_snapshot_;
+  }
+
  private:
   explicit RecentTabHelper(content::WebContents* web_contents);
   friend class content::WebContentsUserData<RecentTabHelper>;
 
 
-  void LazyInitialize();
+  void EnsureInitialized();
   void ContinueSnapshotWithIdsToPurge(const std::vector<int64_t>& page_ids);
   void ContinueSnapshotAfterPurge(OfflinePageModel::DeletePageResult result);
   void SavePageCallback(OfflinePageModel::SavePageResult result,
                         int64_t offline_id);
 
   void ReportSnapshotCompleted();
   bool IsSamePage() const;
   ClientId client_id() const;
 
   // Page model is a service, no ownership.
   OfflinePageModel* page_model_;

[dewittj, 2016/08/24 23:01:39]

please document that page_model_ can be null even during normal operation of
this tab helper

[Dmitry Titov, 2016/08/25 00:36:09]

Done.

   // If false, never make snapshots off the attached WebContents.
+  // Not page-specific.
   bool snapshots_enabled_;
+  // Becomes true during navigation if the page is ready for snapshot as
+  // indicated by at least one callback from SnapshotController.
+  bool is_page_ready_for_snapshot_;
   // If empty, the tab does not have AndroidId and can not capture pages.
   std::string tab_id_;
 
   // The URL of the page that is currently being snapshotted. Used to check,
   // during async operations, that WebContents still contains the same page.
   GURL snapshot_url_;
   std::unique_ptr<SnapshotController> snapshot_controller_;

[dewittj, 2016/08/24 23:01:39]

also document that this starts out null but then lasts the lifetime of the
helper once EnsureInitialized is called.

[Dmitry Titov, 2016/08/25 00:36:09]

Done.

 
   std::unique_ptr<Delegate> delegate_;
 
   base::WeakPtrFactory<RecentTabHelper> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RecentTabHelper);
 };
 
 }  // namespace offline_pages
 #endif  // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_RECENT_TAB_HELPER_H_