Issue 2278763002: Handle empty string messages in Dart_PostCObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2278763002: Handle empty string messages in Dart_PostCObject (Closed)

Created:
4 years, 4 months ago by zra

Modified:
4 years, 3 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	runtime/vm/dart_api_message.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	runtime/vm/snapshot_test.cc	View		3 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

zra

Turns out it just works, I just failed to update the test correctly. Thanks!

4 years, 4 months ago (2016-08-24 22:01:22 UTC) #2

zra

4 years, 3 months ago (2016-08-25 19:39:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
89e81a462008462445ee80cbe21736c15764ed09 (presubmit successful).