Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1589)

Unified Diff: components/metrics/linearhistogram_sample_chromeos.cc

Issue 227873002: Create a histogram serialization mechanism in components/metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moving to components instead of base. Adding sanity checks. Fixing lint Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/linearhistogram_sample_chromeos.cc
diff --git a/components/metrics/linearhistogram_sample_chromeos.cc b/components/metrics/linearhistogram_sample_chromeos.cc
new file mode 100644
index 0000000000000000000000000000000000000000..77ff6ee4fda2b5cdfdaaacf218ac585f362fda80
--- /dev/null
+++ b/components/metrics/linearhistogram_sample_chromeos.cc
@@ -0,0 +1,49 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/metrics/linearhistogram_sample_chromeos.h"
+
+#include <string>
+
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_split.h"
+#include "base/strings/stringprintf.h"
+#include "components/metrics/metric_sample_chromeos.h"
+
+using base::StringPrintf;
+using base::StringToInt;
+using base::SplitString;
+using std::string;
+using std::vector;
+
+namespace metrics {
+
+LinearHistogramSample::LinearHistogramSample(const std::string& histname,
+ int sample,
+ int max)
+ : MetricSample(MetricSample::LINEAR_HISTOGRAM, histname),
+ sample_(sample),
+ max_(max) {}
+
+LinearHistogramSample::~LinearHistogramSample() {}
+
+string LinearHistogramSample::ToString() const {
+ return StringPrintf(
+ "linearhistogram%c%s %d %d%c", '\0', name().c_str(), sample_, max_, '\0');
+}
+
+// static
+LinearHistogramSample* LinearHistogramSample::ReadLinearHistogram(
+ const std::string& histogram_serialized) {
+ vector<string> parts;
+ int sample, max;
+ SplitString(histogram_serialized, ' ', &parts);
+ if (parts.size() != 3) return NULL;
+ if (!StringToInt(parts[1], &sample) || !StringToInt(parts[2], &max))
+ return NULL;
+
+ return new LinearHistogramSample(parts[0], sample, max);
Ben Chan 2014/04/18 20:27:08 see previous comments on commenting serialized for
+}
+
+} // namespace metrics

Powered by Google App Engine
This is Rietveld 408576698