Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: components/metrics/crash_sample_chromeos.h

Issue 227873002: Create a histogram serialization mechanism in components/metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moving to components instead of base. Adding sanity checks. Fixing lint Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/crash_sample_chromeos.h
diff --git a/components/metrics/crash_sample_chromeos.h b/components/metrics/crash_sample_chromeos.h
new file mode 100644
index 0000000000000000000000000000000000000000..eb9ae2966880b589baa6b93d3e2abaec9fd33cf3
--- /dev/null
+++ b/components/metrics/crash_sample_chromeos.h
@@ -0,0 +1,36 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_METRICS_CHROMEOS_CRASH_SAMPLE_CHROMEOS_H
Ben Chan 2014/04/18 20:27:08 nit: I believe the convention is COMPONENTS_ME
+#define COMPONENTS_METRICS_CHROMEOS_CRASH_SAMPLE_CHROMEOS_H
+
+#include <string>
+
+#include "base/base_export.h"
+#include "base/compiler_specific.h"
+#include "components/metrics/metric_sample_chromeos.h"
+
+namespace metrics {
+
+// Represents a crash event described by a simple name.
+class BASE_EXPORT CrashSample : public MetricSample {
+ public:
+ explicit CrashSample(const std::string& crashname);
+ virtual ~CrashSample();
+
+ // Produce a serialized version of the crash.
Ben Chan 2014/04/18 20:27:08 nit: [OCD] the comments in this file and other fil
+ // Format: crash\0|name_|\0
+ virtual std::string ToString() const OVERRIDE;
+
+ // Return a CrashSample object representing the serialized crash if possible.
+ // If the deserialization fails, returns NULL.
+ static CrashSample* ReadCrash(const std::string& crash_serialized);
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(CrashSample);
+};
+
+} // namespace metrics
+
+#endif // COMPONENTS_METRICS_CHROMEOS_CRASH_SAMPLE_CHROMEOS_H

Powered by Google App Engine
This is Rietveld 408576698