Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: components/metrics/chromeos/metrics_utils.h

Issue 227873002: Create a histogram serialization mechanism in components/metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renaming gyp target (nit) Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/chromeos/metrics_utils.h
diff --git a/components/metrics/chromeos/metrics_utils.h b/components/metrics/chromeos/metrics_utils.h
new file mode 100644
index 0000000000000000000000000000000000000000..a359f53dd96ff48cbfbf46b180c2b91ae016f58d
--- /dev/null
+++ b/components/metrics/chromeos/metrics_utils.h
@@ -0,0 +1,45 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_METRICS_CHROMEOS_METRICS_UTILS_H_
+#define COMPONENTS_METRICS_CHROMEOS_METRICS_UTILS_H_
+
+#include <string>
+
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
+
+namespace metrics {
+
+class MetricSample;
+
+// Metrics helpers to serialize and deserialize metrics collected by
+// ChromeOS.
+namespace MetricsUtils {
+
+// Deserialize a sample passed as a string and return a sample.
+// The return value will either be a scoped_ptr to a Metric sample (if the
+// deserialization was successful) or a NULL scoped_ptr.
+scoped_ptr<MetricSample> ReadSample(const std::string& sample);
+
+// Read all samples from a file and truncate the file when done.
+void ReadAndTruncateMetricsFromFile(const std::string& filename,
+ ScopedVector<MetricSample>* metrics);
+
+// Serialize a sample and write it to filename.
+// The format for the message is:
+// message_size, serialized_message
+// where
+// * message_size is the total length of the message (message_size +
+// serialized_message) on 4 bytes
+// * serialized_message is the serialized version of sample (using ToString)
+bool WriteMetricToFile(const MetricSample* sample, const std::string& filename);
+
+// Maximum length of a serialized message
+const int kMessageMaxLength = 1024;
Alexei Svitkine (slow) 2014/05/13 19:52:42 Does this need to be in the header file?
bsimonnet 2014/05/13 21:28:00 I think it does. It needs to be access by the test
+
+} // namespace MetricsUtils
+} // namespace metrics
+
+#endif // COMPONENTS_METRICS_CHROMEOS_METRICS_UTILS_H_

Powered by Google App Engine
This is Rietveld 408576698