Create a histogram serialization mechanism in components/metrics

base/metrics/metric_sample.cc

Index: base/metrics/metric_sample.cc
diff --git a/base/metrics/metric_sample.cc b/base/metrics/metric_sample.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ace50c6ecf9ad3b6e794de835fab5b75f833ee0a
--- /dev/null
+++ b/base/metrics/metric_sample.cc
@@ -0,0 +1,28 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+
+#include "base/logging.h"
+#include "base/metrics/metric_sample.h"
+
+using std::string;
+
+namespace base {
+MetricSample::MetricSample(MetricSample::SampleType sample_type) {

[gauravsh, 2014/04/11 23:50:51]

Use constructor initializer list here (and other places).

See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...

+  type_ = sample_type;
+}
+
+MetricSample::SampleType MetricSample::type() { return type_; }

[gauravsh, 2014/04/11 23:50:51]

NIT: keep order of definition consistent with declaration in .h file

+
+MetricSample::~MetricSample() {}
+
+string MetricSample::toString() const { return "not implemented"; }
+
+bool MetricSample::isValid() const {
+  return name_.find(' ') == string::npos && name_.find('\0') == string::npos;
+}
+
+string MetricSample::name() const { return name_; }
+}  // namespace base