Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: components/metrics/chromeos/histogram_sample.h

Issue 227873002: Create a histogram serialization mechanism in components/metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move files into chromeos. Fixed linting issues. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/chromeos/histogram_sample.h
diff --git a/components/metrics/chromeos/histogram_sample.h b/components/metrics/chromeos/histogram_sample.h
new file mode 100644
index 0000000000000000000000000000000000000000..2048f1be68b2dfe75e87ae0efdeb9561c92de3f5
--- /dev/null
+++ b/components/metrics/chromeos/histogram_sample.h
@@ -0,0 +1,56 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_METRICS_CHROMEOS_HISTOGRAM_SAMPLE_H_
+#define COMPONENTS_METRICS_CHROMEOS_HISTOGRAM_SAMPLE_H_
+
+#include <string>
+
+#include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
+#include "components/metrics/chromeos/metric_sample.h"
+
+namespace metrics {
+
+// Represent a single histogram sample.
+// This class is meant to be used to serialize and deserialize samples to send
+// them from ChromeOS to Chrome.
+class HistogramSample : public MetricSample {
+ public:
+ HistogramSample(const std::string& name,
+ int sample,
+ int min,
+ int max,
+ int nbucket);
+ virtual ~HistogramSample();
+
+ int sample() const { return sample_; }
+ int min() const { return min_; }
+ int max() const { return max_; }
+ int nbucket() const { return nbucket_; }
Luigi Semenzato 2014/05/08 17:19:37 This may be a residual of my old code, but I have
+
+ // Return the sample serialized on the format:
+ // histogram\0|name_| |sample_| |min_| |max_| |nbucket_|\0
+ virtual std::string ToString() const OVERRIDE;
+
+ // Deserialize a histogram passed as a string.
+ // Returns a HistogramSample if the deserialization is successful, otherwise
+ // returns NULL.
+ // The serialized format is a string listing |name|, |sample|, |min|, |max|,
+ // |nbucket| separated by a space.
+ static scoped_ptr<HistogramSample> ReadHistogram(
+ const std::string& serialized_histogram);
+
+ private:
+ const int sample_;
+ const int min_;
+ const int max_;
+ const int nbucket_;
+
+ DISALLOW_COPY_AND_ASSIGN(HistogramSample);
+};
+
+} // namespace metrics
+
+#endif // COMPONENTS_METRICS_CHROMEOS_HISTOGRAM_SAMPLE_H_

Powered by Google App Engine
This is Rietveld 408576698