Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Unified Diff: components/metrics/export/linearhistogram_sample.h

Issue 227873002: Create a histogram serialization mechanism in components/metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Convert to use scoped_ptr. Remove using declarations. Fixed linting. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/export/linearhistogram_sample.h
diff --git a/components/metrics/export/linearhistogram_sample.h b/components/metrics/export/linearhistogram_sample.h
new file mode 100644
index 0000000000000000000000000000000000000000..8cc2829897dc1114f67727245a841e0b35915727
--- /dev/null
+++ b/components/metrics/export/linearhistogram_sample.h
@@ -0,0 +1,46 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_METRICS_EXPORT_LINEARHISTOGRAM_SAMPLE_H_
+#define COMPONENTS_METRICS_EXPORT_LINEARHISTOGRAM_SAMPLE_H_
+
+#include <string>
+
+#include "base/base_export.h"
+#include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
+#include "components/metrics/export/metric_sample.h"
+
+namespace metrics {
+
+// Represent a linear histogram sample (called Enum too).
+// This class is meant to be used to serialize and deserialize samples to send
+// them from ChromeOS to Chrome.
+class BASE_EXPORT LinearHistogramSample : public MetricSample {
+ public:
+ LinearHistogramSample(const std::string& name, int sample, int max);
+ virtual ~LinearHistogramSample();
+
+ int sample() const { return sample_; }
+ int max() const { return max_; }
+
+ // Return the serialized version of the sample in the format:
+ // linearhistogram\0|name_| |sample_| |max_|\0
+ virtual std::string ToString() const OVERRIDE;
+
+ // Deserialize a sample passed as a string.
+ // Returns a LinearHistogram if the deserialization is successful.
+ // Returns NULL if the deserialization fails.
+ static scoped_ptr<LinearHistogramSample> ReadLinearHistogram(
+ const std::string& serialized_histogram);
+
+ private:
+ const int sample_, max_;
Alexei Svitkine (slow) 2014/05/01 15:57:09 Nit: 1 per line.
bsimonnet 2014/05/01 20:34:21 Done.
+
+ DISALLOW_COPY_AND_ASSIGN(LinearHistogramSample);
+};
+
+} // namespace metrics
+
+#endif // COMPONENTS_METRICS_EXPORT_LINEARHISTOGRAM_SAMPLE_H_

Powered by Google App Engine
This is Rietveld 408576698