Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: components/metrics/export/sparsehistogram_sample.h

Issue 227873002: Create a histogram serialization mechanism in components/metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Running tests only for chromeos. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/export/sparsehistogram_sample.h
diff --git a/components/metrics/export/sparsehistogram_sample.h b/components/metrics/export/sparsehistogram_sample.h
new file mode 100644
index 0000000000000000000000000000000000000000..497b041d8c0d7ab8ff5a09a1da7fce663cdbc52a
--- /dev/null
+++ b/components/metrics/export/sparsehistogram_sample.h
@@ -0,0 +1,43 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_METRICS_EXPORT_SPARSEHISTOGRAM_SAMPLE_H_
+#define COMPONENTS_METRICS_EXPORT_SPARSEHISTOGRAM_SAMPLE_H_
+
+#include <string>
+
+#include "base/base_export.h"
+#include "base/compiler_specific.h"
+#include "components/metrics/export/metric_sample.h"
+
+namespace metrics {
+
+// Represent a sparse histogram sample.
+// This class is meant to be used to serialize and deserialize a sample to send
+// it from ChromeOS to Chrome.
+class BASE_EXPORT SparseHistogramSample : public MetricSample {
+ public:
+ SparseHistogramSample(const std::string& name, int sample);
+ virtual ~SparseHistogramSample();
+
+ int sample() const { return sample_; }
+ // Serialize a sample on the format:
Alexei Svitkine (slow) 2014/04/30 15:25:24 Nit: Add a blank line above this.
bsimonnet 2014/04/30 20:28:40 Done.
+ // sparsehistogram\0|name_| |sample_|\0
+ virtual std::string ToString() const OVERRIDE;
+
+ // Deserialize a sample passed as a string.
+ // Returns a SparseHistogramSample if the deserialization works or NULL if it
+ // fails.
+ static SparseHistogramSample* ReadSparseHistogram(
+ const std::string& serialized_histogram);
+
+ private:
+ const int sample_;
+
+ DISALLOW_COPY_AND_ASSIGN(SparseHistogramSample);
+};
+
+} // namespace metrics
+
+#endif // COMPONENTS_METRICS_EXPORT_SPARSEHISTOGRAM_SAMPLE_H_

Powered by Google App Engine
This is Rietveld 408576698