components/metrics/README - Issue 227873002: Create a histogram serialization mechanism in components/metrics

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/metrics/README

Issue 227873002: Create a histogram serialization mechanism in components/metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rewriting the file manipulation to using blocking locks (using flock) Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/metrics.gypi ('K') | « components/metrics.gypi ('k') | components/metrics/chromeos/metric_sample.h » ('j') | components/metrics/chromeos/metric_sample.cc » ('J')

OLD	NEW
1 This component contains the base classes for the metrics service and only	1 This component contains the base classes for the metrics service and only

2 depends on //base. It is used by ChromeOS as the base for a standalone service	2 depends on //base. It is used by ChromeOS as the base for a standalone service

3 that will upload the metrics when ChromeOS is not installed (headless install).	3 that will upload the metrics when ChromeOS is not installed (headless install).

4	4

5 This is the first step towards the componentization of metrics that will happen	5 This is the first step towards the componentization of metrics that will happen

6 later this spring.	6 later this spring.

7	7

8 A proposed structure for the metrics component is:	8 A proposed structure for the metrics component is:

9 //components/metrics/base,	9 //components/metrics/base,

10 Depends on base only. Contains the protobuf definitions.	10 Depends on base only. Contains the protobuf definitions.

11 //components/metrics/core	11 //components/metrics/core

12 Depends on everything iOS depends on	12 Depends on everything iOS depends on

13 //components/metrics/content	13 //components/metrics/content

14 Depends on content	14 Depends on content

15	15

16 Ideally, the component would abstract the network stack and have a clean	16 Ideally, the component would abstract the network stack and have a clean

17 separation between the metrics upload logic (protbuf generation, retry, etc...),	17 separation between the metrics upload logic (protbuf generation, retry, etc...),

18 the chrome part (gathering histogram from all the threads, populating the	18 the chrome part (gathering histogram from all the threads, populating the

19 log with hardware characteristics, plugin state, etc.).	19 log with hardware characteristics, plugin state, etc.).

20	20

21 It is a plus if the component stays in a single directory as it would be easier	21 It is a plus if the code currently in the component (i.e., the code that can

	22 depend only on //base) stays in a single directory as it would be easier

22 for ChromeOS to pull it :).	23 for ChromeOS to pull it :).

OLD	NEW