Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: base/metrics/sparsehistogram_sample.h

Issue 227873002: Create a histogram serialization mechanism in components/metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactoring to use string instead of char buffers Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef BASE_METRICS_SPARSEHISTOGRAM_SAMPLE_H
6 #define BASE_METRICS_SPARSEHISTOGRAM_SAMPLE_H
7
8 #include <string>
9
10 #include "base/base_export.h"
11 #include "base/metrics/metric_sample.h"
12
13 namespace base {
14 class BASE_EXPORT SparseHistogramSample : public MetricSample {
15 public:
16 SparseHistogramSample(const std::string& histname, int sample);
17 virtual ~SparseHistogramSample();
18 int sample();
gauravsh 2014/04/11 23:50:51 this can be a const function.
19 // static
20 static SparseHistogramSample* ReadSparseHistogram(
gauravsh 2014/04/11 23:50:51 Needs comment.
21 const std::string& serializedhist);
gauravsh 2014/04/11 23:50:51 NIT: serialized_hist. Also avoid abbreviations whe
22 string toString() const;
23
24 protected:
25 int sample_;
gauravsh 2014/04/11 23:50:51 Do you intend to subclass this? make this private.
26 };
27 } // namespace base
28 #endif // BASE_METRICS_SPARSEHISTOGRAM_SAMPLE_H
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698