Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2278723006: [Media Router WebUI] Use updated sink on click (Closed)

Created:
4 years, 3 months ago by mark a. foltz
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Use updated sink on click Since crrev.com/2221933003, the dom-repeat element that creates the sink list doesn't seem to correctly update its element-item mapping. Instead we will use the most current sink object with the same ID in our own map. BUG=637222 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2252313002 Cr-Commit-Position: refs/heads/master@{#413573} (cherry picked from commit 7e3c3e80f15d513f9c2fe7a59b1854c7e1ff47e9) Committed: https://chromium.googlesource.com/chromium/src/+/6ecece00c2f3b6736fdd4d9a4d92313fa718ad8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mark a. foltz
4 years, 3 months ago (2016-08-25 19:00:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ecece00c2f3b6736fdd4d9a4d92313fa718ad8d.

Powered by Google App Engine
This is Rietveld 408576698