Use StringPiece more in base::Value interfaces.

Use StringPiece more in base::Value interfaces.

Many of these functions are called with string literals.
This leads to two problems:
- Implicit construction of std::string generates a
  surprising amount of code, since STL code is often
  inlined.
- We construct a temporary string, immediately copy it,
  and then throw away the original temporary.

Effect of this CL on an official Linux binary:
 before: 100.41 MiB
  after: 99.56 MiB

BUG=none

Committed: https://crrev.com/16d6f53c350781fc725ea33d8e74c66a4b49c9bf
Cr-Commit-Position: refs/heads/master@{#414450}

[dcheng, 2016-08-25 07:35:11]

Description was changed from

==========
Use StringPiece more in base::Value interfaces.

BUG=none
==========

to

==========
Use StringPiece more in base::Value interfaces.

Many of these functions are called with string literals.
This leads to two problems:
- Implicit construction of std::string generates a
  surprising amount of code, since STL code is often
  inlined.
- We construct a temporary string, immediately copy it,
  and then throw away the original temporary.

Effect of this CL on an official Linux binary:
 before: 100.41 MiB
  after: 99.56 MiB

BUG=none
==========

[dcheng, 2016-08-25 07:35:12]

dcheng@chromium.org changed reviewers:
+ thakis@chromium.org

[dcheng, 2016-08-25 07:35:19]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 07:35:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-08-25 07:39:34]

https://codereview.chromium.org/2278723003/diff/1/base/values.h
File base/values.h (right):

https://codereview.chromium.org/2278723003/diff/1/base/values.h#newcode155
base/values.h:155: explicit StringValue(const string16& in_value);
I didn't bother with string16, since calling this with a literal is currently
much more rare. The only place this is likely to happen is on Windows. Perhaps
this will change once we have Unicode literals?

https://codereview.chromium.org/2278723003/diff/1/chrome/browser/ui/webui/plu...
File chrome/browser/ui/webui/plugins/plugins_handler.cc (right):

https://codereview.chromium.org/2278723003/diff/1/chrome/browser/ui/webui/plu...
chrome/browser/ui/webui/plugins/plugins_handler.cc:174:
update->SetBoolean(plugin.get(), allowed);
mojo::String will go away eventually, I guess.

[commit-bot: I haz the power, 2016-08-25 07:55:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 07:55:35]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-08-25 08:15:52]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 08:16:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-08-25 08:16:41]

dcheng@chromium.org changed reviewers:
+ juliatuttle@chromium.org, lhchavez@chromium.org

[dcheng, 2016-08-25 08:17:21]

+juliatuttle for domain reliability
+lhchavez for arc++

[commit-bot: I haz the power, 2016-08-25 09:57:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 09:57:57]

Dry run: This issue passed the CQ dry run.

[Julia Tuttle, 2016-08-25 13:09:28]

On 2016/08/25 08:17:21, dcheng wrote:
> +juliatuttle for domain reliability

components/domain_reliability lgtm!

[Luis Héctor Chávez, 2016-08-25 15:32:22]

components/arc lgtm

[Nico, 2016-08-25 15:37:13]

lgtm, nice!

[dcheng, 2016-08-25 16:02:07]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-08-25 16:02:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 16:07:27]

Description was changed from

==========
Use StringPiece more in base::Value interfaces.

Many of these functions are called with string literals.
This leads to two problems:
- Implicit construction of std::string generates a
  surprising amount of code, since STL code is often
  inlined.
- We construct a temporary string, immediately copy it,
  and then throw away the original temporary.

Effect of this CL on an official Linux binary:
 before: 100.41 MiB
  after: 99.56 MiB

BUG=none
==========

to

==========
Use StringPiece more in base::Value interfaces.

Many of these functions are called with string literals.
This leads to two problems:
- Implicit construction of std::string generates a
  surprising amount of code, since STL code is often
  inlined.
- We construct a temporary string, immediately copy it,
  and then throw away the original temporary.

Effect of this CL on an official Linux binary:
 before: 100.41 MiB
  after: 99.56 MiB

BUG=none
==========

[commit-bot: I haz the power, 2016-08-25 16:07:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 16:09:16]

Description was changed from

==========
Use StringPiece more in base::Value interfaces.

Many of these functions are called with string literals.
This leads to two problems:
- Implicit construction of std::string generates a
  surprising amount of code, since STL code is often
  inlined.
- We construct a temporary string, immediately copy it,
  and then throw away the original temporary.

Effect of this CL on an official Linux binary:
 before: 100.41 MiB
  after: 99.56 MiB

BUG=none
==========

to

==========
Use StringPiece more in base::Value interfaces.

Many of these functions are called with string literals.
This leads to two problems:
- Implicit construction of std::string generates a
  surprising amount of code, since STL code is often
  inlined.
- We construct a temporary string, immediately copy it,
  and then throw away the original temporary.

Effect of this CL on an official Linux binary:
 before: 100.41 MiB
  after: 99.56 MiB

BUG=none

Committed: https://crrev.com/16d6f53c350781fc725ea33d8e74c66a4b49c9bf
Cr-Commit-Position: refs/heads/master@{#414450}
==========

[commit-bot: I haz the power, 2016-08-25 16:09:17]

Patchset 2 (id:??) landed as
https://crrev.com/16d6f53c350781fc725ea33d8e74c66a4b49c9bf
Cr-Commit-Position: refs/heads/master@{#414450}