Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2278673003: DevTools: Remove stray event handlers from CMTE (Closed)

Created:
4 years, 4 months ago by einbinder
Modified:
4 years, 4 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Remove stray event handlers from CMTE BUG=none Committed: https://crrev.com/79b2f877b96f0ac888508e94d9c69fa26651bed0 Cr-Commit-Position: refs/heads/master@{#414178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
einbinder
Ptal. I forgot to remove some event handlers in my patch to spin off SourcesTextEditor ...
4 years, 4 months ago (2016-08-24 20:51:28 UTC) #2
lushnikov
дпеь
4 years, 4 months ago (2016-08-24 21:54:23 UTC) #5
lushnikov
lgtm
4 years, 4 months ago (2016-08-24 21:54:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278673003/1
4 years, 4 months ago (2016-08-24 21:55:05 UTC) #9
lushnikov
let's add a test in a follow-up!
4 years, 4 months ago (2016-08-24 21:55:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 22:39:56 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 22:42:13 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/79b2f877b96f0ac888508e94d9c69fa26651bed0
Cr-Commit-Position: refs/heads/master@{#414178}

Powered by Google App Engine
This is Rietveld 408576698