Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2278673002:
GN: misc (Closed)
|
Created:
4 years, 4 months ago by mtklein_C Modified:
4 years, 3 months ago Reviewers:
jcgregorio CC:
anmittal, reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionGN: misc
- Use options' template pattern for opts too.
- Simplify opt's and options' configs... they should all be the same.
- When building a static-library component in our GN environment (i.e. libskia.a),
make it a complete static lib, fully containing its transitive deps.
- It has not proved useful to override ar.
TBR=jcgregorio@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
Committed: https://skia.googlesource.com/skia/+/9b8583dd1f18657c08eaab047d79288b9f2c61a7
Patch Set 1 #Patch Set 2 : simpler #
Messages
Total messages: 20 (15 generated)
Description was changed from
==========
GN: misc
- Use options' template pattern for opts too.
- Fold more into options' and opt's default configs.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its deps.
- It has not been useful to override ar.
BUG=skia:
==========
to
==========
GN: misc
- Use options' template pattern for opts too.
- Fold more into options' and opt's default configs.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its deps.
- It has not been useful to override ar.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
GN: misc
- Use options' template pattern for opts too.
- Fold more into options' and opt's default configs.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its deps.
- It has not been useful to override ar.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
==========
to
==========
GN: misc
- Use options' template pattern for opts too.
- Fold more into options' and opts' default configs.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its deps.
- It has not been useful to override ar.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
==========
Description was changed from
==========
GN: misc
- Use options' template pattern for opts too.
- Fold more into options' and opts' default configs.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its deps.
- It has not been useful to override ar.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
==========
to
==========
GN: misc
- Use options' template pattern for opts too.
- Fold more into options' and opts' default configs.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its transitive deps.
- It has not been useful to override ar.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
==========
Description was changed from
==========
GN: misc
- Use options' template pattern for opts too.
- Fold more into options' and opts' default configs.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its transitive deps.
- It has not been useful to override ar.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
==========
to
==========
GN: misc
- Use options' template pattern for opts too.
- Fold more into options' and opts' default configs.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its transitive deps.
- It has not proved useful to override ar.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
==========
Description was changed from
==========
GN: misc
- Use options' template pattern for opts too.
- Fold more into options' and opts' default configs.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its transitive deps.
- It has not proved useful to override ar.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
==========
to
==========
GN: misc
- Use options' template pattern for opts too.
- Simplify opt's and options' configs... they should all be the same.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its transitive deps.
- It has not proved useful to override ar.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mtklein@chromium.org changed reviewers: + jcgregorio@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from
==========
GN: misc
- Use options' template pattern for opts too.
- Simplify opt's and options' configs... they should all be the same.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its transitive deps.
- It has not proved useful to override ar.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
==========
to
==========
GN: misc
- Use options' template pattern for opts too.
- Simplify opt's and options' configs... they should all be the same.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its transitive deps.
- It has not proved useful to override ar.
TBR=jcgregorio@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
==========
The CQ bit was checked by mtklein@chromium.org
Gonna land this TBR. I have it on Good Authority (cc'd) that this CL's config refactoring in skia/BUILD.gn is actually the last piece of the puzzle to rolling Skia in Fuchsia.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
GN: misc
- Use options' template pattern for opts too.
- Simplify opt's and options' configs... they should all be the same.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its transitive deps.
- It has not proved useful to override ar.
TBR=jcgregorio@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
==========
to
==========
GN: misc
- Use options' template pattern for opts too.
- Simplify opt's and options' configs... they should all be the same.
- When building a static-library component in our GN environment (i.e.
libskia.a),
make it a complete static lib, fully containing its transitive deps.
- It has not proved useful to override ar.
TBR=jcgregorio@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002
Committed:
https://skia.googlesource.com/skia/+/9b8583dd1f18657c08eaab047d79288b9f2c61a7
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/9b8583dd1f18657c08eaab047d79288b9f2c61a7
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
