Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2278653003: Reland of "[heap] Switch to 500k pages" (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan, Toon Verwaest
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Switch to 500k pages Decrease regular heap object size to 400k. In a follow up, we can now get rid of the new space border page while keeping the 1M minimum new space size. This reverts commit 1617043c1093870d67eede7828467cc3b77ba9fb. BUG=chromium:636331 Committed: https://crrev.com/2101e691caeef656eb91f1c98620b3955d337c83 Cr-Commit-Position: refs/heads/master@{#38916}

Patch Set 1 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -131 lines) Patch
M src/base/build_config.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +13 lines, -2 lines 0 comments Download
M src/heap/spaces.cc View 5 chunks +71 lines, -10 lines 0 comments Download
M src/isolate.cc View 2 chunks +13 lines, -9 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/snapshot/snapshot.h View 2 chunks +4 lines, -12 lines 0 comments Download
M src/snapshot/snapshot-common.cc View 4 chunks +3 lines, -67 lines 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 4 chunks +20 lines, -7 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 4 chunks +117 lines, -8 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Michael Lippautz
please stamp (or re-review if you like). The bug that was flushed out (crbug.com/637279) is ...
4 years, 3 months ago (2016-08-25 15:02:55 UTC) #3
ulan
lgtm
4 years, 3 months ago (2016-08-25 15:03:16 UTC) #4
Toon Verwaest
rubberstamp lgtm
4 years, 3 months ago (2016-08-25 15:16:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278653003/1
4 years, 3 months ago (2016-08-25 16:24:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 16:26:09 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2101e691caeef656eb91f1c98620b3955d337c83 Cr-Commit-Position: refs/heads/master@{#38916}
4 years, 3 months ago (2016-08-25 16:26:41 UTC) #15
Michael Lippautz
4 years, 3 months ago (2016-08-28 07:02:46 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2289493002/ by mlippautz@chromium.org.

The reason for reverting is: Tanks pretty much alle metrics across the board.
Probably LO space limit too low but needs investigation..

Powered by Google App Engine
This is Rietveld 408576698