Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2278643002: Do not trigger ExceptionEvents for another forwarding case (Closed)

Created:
4 years, 4 months ago by Dan Ehrenberg
Modified:
4 years, 4 months ago
Reviewers:
kozy, adamk, jgruber
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not trigger ExceptionEvents for another forwarding case This patch fixes up one last case of redundant ExceptionEvents being triggered in the debugger for Promises--it makes the default reject handler for Promises (e.g., if the second argument for Promise.prototype.then is missing) appear to the debugger as a rethrow. R=adamk@chromium.org,jgruber@chromium.org BUG=v8:5167 Committed: https://crrev.com/aae17eb31b5bafb3c95b000ce351b9c690ce6791 Cr-Commit-Position: refs/heads/master@{#38876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -29 lines) Patch
M src/js/promise.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-by-default-reject-handler.js View 2 chunks +7 lines, -13 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-by-default-reject-handler.js View 2 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Dan Ehrenberg
4 years, 4 months ago (2016-08-24 18:36:56 UTC) #3
adamk
Thus intuitively seems right to me and lgtm from code side, but want to make ...
4 years, 4 months ago (2016-08-24 20:28:22 UTC) #7
kozy
lgtm
4 years, 4 months ago (2016-08-24 20:31:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278643002/1
4 years, 4 months ago (2016-08-24 20:35:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 20:38:04 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 20:38:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aae17eb31b5bafb3c95b000ce351b9c690ce6791
Cr-Commit-Position: refs/heads/master@{#38876}

Powered by Google App Engine
This is Rietveld 408576698