Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: runtime/vm/parser.cc

Issue 227863002: Add const static field optimization that got lost in last checkin (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 34791)
+++ runtime/vm/parser.cc (working copy)
@@ -10558,6 +10558,14 @@
} else if (expr->IsLoadLocalNode() &&
expr->AsLoadLocalNode()->local().IsConst()) {
return *expr->AsLoadLocalNode()->local().ConstValue();
+ } else if (expr->IsLoadStaticFieldNode()) {
+ const Field& field = expr->AsLoadStaticFieldNode()->field();
+ // We already checked that this field is const and has been
+ // initialized.
+ ASSERT(field.is_const());
+ ASSERT(field.value() != Object::sentinel().raw());
+ ASSERT(field.value() != Object::transition_sentinel().raw());
+ return Instance::ZoneHandle(field.value());
} else {
ASSERT(expr->EvalConstExpr() != NULL);
ReturnNode* ret = new ReturnNode(expr->token_pos(), expr);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698