Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2278613003: Drop CPDFSDK_PageView::Annot_HasAppearance (Closed)

Created:
4 years, 3 months ago by tonikitoo
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Drop CPDFSDK_PageView::Annot_HasAppearance Method is unused and misplaced (it should be in CPF_Annot if actually needed). Committed: https://pdfium.googlesource.com/pdfium/+/e5cbb33e2d6db82c2904dae689eb38b7a4587297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M fpdfsdk/fsdk_mgr.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
tonikitoo
Driven by CL.
4 years, 3 months ago (2016-08-25 14:31:50 UTC) #4
dsinclair
lgtm
4 years, 3 months ago (2016-08-25 14:32:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278613003/1
4 years, 3 months ago (2016-08-25 14:32:40 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 14:42:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/e5cbb33e2d6db82c2904dae689eb38b7a458...

Powered by Google App Engine
This is Rietveld 408576698