Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: runtime/vm/service.cc

Issue 2278613002: Do not allow a hot reload if the isolate has a sticky error (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Do not allow a hot reload if the isolate has a sticky error Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/json_stream.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index d29a658cb8ef19ce4523a3a58efa5dff3b43e29d..a0df953a460b0230b6351df8e457dfc315091596 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2520,6 +2520,13 @@ static bool ReloadSources(Thread* thread, JSONStream* js) {
"A library tag handler must be installed.");
return true;
}
+ if ((isolate->sticky_error() != Error::null()) ||
+ (Thread::Current()->sticky_error() != Error::null())) {
+ js->PrintError(kIsolateReloadBarred,
+ "This isolate cannot reload sources anymore because there "
+ "was an unhandled exception error. Restart the isolate.");
+ return true;
+ }
if (isolate->IsReloading()) {
js->PrintError(kIsolateIsReloading,
"This isolate is being reloaded.");
« no previous file with comments | « runtime/vm/json_stream.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698