Do not allow a hot reload if the isolate has a sticky error

Do not allow a hot reload if the isolate has a sticky error

BUG=
R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/d8eb5ffb573b28135a21ea2c7340f69c7578f831

[Cutch, 2016-08-24 16:34:13]

Description was changed from

==========
Do not allow a hot reload if the isolate has a sticky error

BUG=
==========

to

==========
Do not allow a hot reload if the isolate has a sticky error

BUG=
==========

[Cutch, 2016-08-24 16:34:13]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[siva, 2016-08-24 17:53:23]

asiva@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-08-24 17:53:24]

DBC.

https://codereview.chromium.org/2278613002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2278613002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:2213: // Remaining service extension calls are dropped.
Should this error also be posted back over the protocol so that clients
listening are aware of it?

https://codereview.chromium.org/2278613002/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/2278613002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2527: "was an unhandled exception error. Restart the
isolate.");
Would it be worth printing the error string here so folks know what the
unhandled error was?

[turnidge, 2016-08-24 18:08:39]

lgtm once you figure out Siva's suggestions.

[Cutch, 2016-08-24 18:30:49]

https://codereview.chromium.org/2278613002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2278613002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:2213: // Remaining service extension calls are dropped.
On 2016/08/24 17:53:24, siva wrote:
> Should this error also be posted back over the protocol so that clients
> listening are aware of it?

The code Service::PostError is actually responding to the JSON-RPC request. The
idea is that if the function that implements the service extension throws an
error that we should send back a JSON-RPC error so the client doesn't wait
forever. If the microtask queue generates an error we can't be certain that it
means the service request wasn't already responded to.

https://codereview.chromium.org/2278613002/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/2278613002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2527: "was an unhandled exception error. Restart the
isolate.");
On 2016/08/24 17:53:24, siva wrote:
> Would it be worth printing the error string here so folks know what the
> unhandled error was?

The clients can grab the error over the service protocol.

[Cutch, 2016-08-24 18:31:52]

Description was changed from

==========
Do not allow a hot reload if the isolate has a sticky error

BUG=
==========

to

==========
Do not allow a hot reload if the isolate has a sticky error

BUG=
R=turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d8eb5ffb573b28135a21ea2c7340f69c7578f831
==========

[Cutch, 2016-08-24 18:31:53]

Committed patchset #2 (id:20001) manually as
d8eb5ffb573b28135a21ea2c7340f69c7578f831 (presubmit successful).