Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 2278603003: Remove SDK extension support from PubSummaryManager. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove SDK extension support from PubSummaryManager. As we discussed, the Flutter SDK bundle contains everything - the libraries from the Flutter embedder, and also the extension library. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2b087ee444b9e3ee92602515417f97ed5cf051fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -392 lines) Patch
M pkg/analyzer/lib/src/summary/pub_summary.dart View 8 chunks +6 lines, -99 lines 0 comments Download
M pkg/analyzer/test/src/summary/pub_summary_test.dart View 3 chunks +0 lines, -293 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 3 months ago (2016-08-24 20:08:26 UTC) #1
Paul Berry
lgtm
4 years, 3 months ago (2016-08-24 20:14:27 UTC) #2
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-08-24 20:48:02 UTC) #3
scheglov
4 years, 3 months ago (2016-08-24 20:51:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b087ee444b9e3ee92602515417f97ed5cf051fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698