Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2278583002: Cleanup some PWL_FontMap methods (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup some PWL_FontMap methods This CL makes some methods private which are only used internally, removes unused methods and removes an unused class. Committed: https://pdfium.googlesource.com/pdfium/+/0e3e890ba53ee7900ba44ebe50fecba21d086bfc

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -49 lines) Patch
M fpdfsdk/pdfwindow/PWL_FontMap.h View 1 2 chunks +9 lines, -25 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 1 4 chunks +5 lines, -24 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
dsinclair
PTAL.
4 years, 4 months ago (2016-08-24 16:02:44 UTC) #4
Wei Li
https://codereview.chromium.org/2278583002/diff/1/fpdfsdk/pdfwindow/PWL_FontMap.cpp File fpdfsdk/pdfwindow/PWL_FontMap.cpp (left): https://codereview.chromium.org/2278583002/diff/1/fpdfsdk/pdfwindow/PWL_FontMap.cpp#oldcode279 fpdfsdk/pdfwindow/PWL_FontMap.cpp:279: if (m_pSystemHandler) { No longer need the check? Ditto ...
4 years, 3 months ago (2016-08-24 16:54:06 UTC) #7
dsinclair
https://codereview.chromium.org/2278583002/diff/1/fpdfsdk/pdfwindow/PWL_FontMap.cpp File fpdfsdk/pdfwindow/PWL_FontMap.cpp (left): https://codereview.chromium.org/2278583002/diff/1/fpdfsdk/pdfwindow/PWL_FontMap.cpp#oldcode279 fpdfsdk/pdfwindow/PWL_FontMap.cpp:279: if (m_pSystemHandler) { On 2016/08/24 16:54:06, Wei Li wrote: ...
4 years, 3 months ago (2016-08-24 17:47:41 UTC) #10
Wei Li
lgtm
4 years, 3 months ago (2016-08-24 18:37:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278583002/20001
4 years, 3 months ago (2016-08-24 18:39:10 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 18:39:27 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/0e3e890ba53ee7900ba44ebe50fecba21d08...

Powered by Google App Engine
This is Rietveld 408576698