Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2278523002: [api] Add documentation for PropertyCallbackInfo.This(). (Closed)

Created:
4 years, 4 months ago by Franzi
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@DocPropertyCallbackInfo
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Add documentation for PropertyCallbackInfo.This(). BUG=v8:5260 Committed: https://crrev.com/5aa7230516a2ed74a547d40c0ac2c0896645c953 Cr-Commit-Position: refs/heads/master@{#38949}

Patch Set 1 #

Patch Set 2 : Do not use cctest isolate in documentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M include/v8.h View 1 1 chunk +41 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Franzi
Hi, I tried to improve the documentation for This(). PTAL. Thanks, Franzi
4 years, 4 months ago (2016-08-24 12:05:04 UTC) #2
jochen (gone - plz use gerrit)
deferring to Toon for correctness
4 years, 4 months ago (2016-08-24 12:07:56 UTC) #3
Toon Verwaest
lgtm
4 years, 3 months ago (2016-08-26 14:47:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278523002/20001
4 years, 3 months ago (2016-08-26 15:50:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 16:15:40 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 16:16:04 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5aa7230516a2ed74a547d40c0ac2c0896645c953
Cr-Commit-Position: refs/heads/master@{#38949}

Powered by Google App Engine
This is Rietveld 408576698