Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2278513002: Remove scopeinfo.h (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove scopeinfo.h It's an empty header. R=verwaest@chromium.org BUG= Committed: https://crrev.com/442336409fe49015558e3f2fda2187a43de35efb Cr-Commit-Position: refs/heads/master@{#38867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D src/ast/scopeinfo.h View 1 chunk +0 lines, -18 lines 0 comments Download
M src/ast/scopeinfo.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-08-24 11:06:58 UTC) #1
Toon Verwaest
lgtm
4 years, 4 months ago (2016-08-24 14:20:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278513002/1
4 years, 4 months ago (2016-08-24 14:26:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 14:28:07 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 14:28:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/442336409fe49015558e3f2fda2187a43de35efb
Cr-Commit-Position: refs/heads/master@{#38867}

Powered by Google App Engine
This is Rietveld 408576698