Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2278493004: Document ARC support for Chrome policies (Closed)

Created:
4 years, 3 months ago by bartfab (slow)
Modified:
4 years, 3 months ago
Reviewers:
flackr, dsansome, phweiss
CC:
chromium-reviews, tnagel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Document ARC support for Chrome policies We distinguish three cases: * Policies that control browser behavior. These implicitly apply to Chrome on Chrome OS only. No documentation updates are needed. * Policies that affect parts of the system which lie outside the scope of ARC, e.g. the login screen and auto-update system. These implicitly apply to Chrome OS only. No documentation updates are needed. * Policies that directly or indirectly influence app behavior. The default assumption is that any such policy applies to both Chrome and Android apps. This CL adds a note to the generated documentation whenever this is not the case. BUG=b/28039197 b/28109303 TEST=ninja -C out/out policy_templates Committed: https://crrev.com/36ad7565635f6f8955b798c1f8e9313cafd156d6 Cr-Commit-Position: refs/heads/master@{#415140}

Patch Set 1 #

Patch Set 2 : Make grit process placeholders. #

Total comments: 2

Patch Set 3 : Added unit test. #

Total comments: 13

Patch Set 4 : Updated policy descriptions. #

Total comments: 2

Patch Set 5 : Fixed typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -22 lines) Patch
M components/policy/resources/policy_templates.json View 1 2 3 4 53 chunks +69 lines, -18 lines 0 comments Download
M components/policy/tools/syntax_check_policy_template_json.py View 2 chunks +4 lines, -1 line 0 comments Download
M tools/grit/grit/format/policy_templates/policy_template_generator.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/grit/grit/format/policy_templates/writers/doc_writer.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py View 1 2 3 chunks +45 lines, -1 line 0 comments Download
M tools/grit/grit/gather/policy_json.py View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 30 (11 generated)
bartfab (slow)
Hi Rob, Could you take a look at the grit changes please? Hi Philipp, Could ...
4 years, 3 months ago (2016-08-25 13:18:09 UTC) #2
flackr
https://codereview.chromium.org/2278493004/diff/20001/tools/grit/grit/format/policy_templates/writers/doc_writer.py File tools/grit/grit/format/policy_templates/writers/doc_writer.py (right): https://codereview.chromium.org/2278493004/diff/20001/tools/grit/grit/format/policy_templates/writers/doc_writer.py#newcode543 tools/grit/grit/format/policy_templates/writers/doc_writer.py:543: self._AddParagraphs(dl, policy['arc_support']) Please add a test for this to ...
4 years, 3 months ago (2016-08-25 15:07:07 UTC) #3
bartfab (slow)
https://codereview.chromium.org/2278493004/diff/20001/tools/grit/grit/format/policy_templates/writers/doc_writer.py File tools/grit/grit/format/policy_templates/writers/doc_writer.py (right): https://codereview.chromium.org/2278493004/diff/20001/tools/grit/grit/format/policy_templates/writers/doc_writer.py#newcode543 tools/grit/grit/format/policy_templates/writers/doc_writer.py:543: self._AddParagraphs(dl, policy['arc_support']) On 2016/08/25 15:07:07, flackr wrote: > Please ...
4 years, 3 months ago (2016-08-26 09:58:36 UTC) #4
phweiss
https://codereview.chromium.org/2278493004/diff/40001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2278493004/diff/40001/components/policy/resources/policy_templates.json#newcode1653 components/policy/resources/policy_templates.json:1653: 'arc_support': 'Only a subset of proxy configuration options are ...
4 years, 3 months ago (2016-08-26 16:30:17 UTC) #5
flackr
grit lgtm https://codereview.chromium.org/2278493004/diff/40001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2278493004/diff/40001/components/policy/resources/policy_templates.json#newcode8972 components/policy/resources/policy_templates.json:8972: 'doc_arc_support': { On 2016/08/26 at 16:30:16, phweiss ...
4 years, 3 months ago (2016-08-26 17:50:57 UTC) #6
bartfab (slow)
https://codereview.chromium.org/2278493004/diff/40001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2278493004/diff/40001/components/policy/resources/policy_templates.json#newcode1653 components/policy/resources/policy_templates.json:1653: 'arc_support': 'Only a subset of proxy configuration options are ...
4 years, 3 months ago (2016-08-29 12:25:36 UTC) #7
phweiss
https://codereview.chromium.org/2278493004/diff/60001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2278493004/diff/60001/components/policy/resources/policy_templates.json#newcode6036 components/policy/resources/policy_templates.json:6036: 'arc_support': 'This policy has no effect on the Android ...
4 years, 3 months ago (2016-08-29 12:40:33 UTC) #8
bartfab (slow)
https://codereview.chromium.org/2278493004/diff/60001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2278493004/diff/60001/components/policy/resources/policy_templates.json#newcode6036 components/policy/resources/policy_templates.json:6036: 'arc_support': 'This policy has no effect on the Android ...
4 years, 3 months ago (2016-08-29 12:59:22 UTC) #9
phweiss
lgtm, thanks.
4 years, 3 months ago (2016-08-29 13:03:45 UTC) #10
bartfab (slow)
4 years, 3 months ago (2016-08-29 13:04:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278493004/80001
4 years, 3 months ago (2016-08-29 13:06:25 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/131975)
4 years, 3 months ago (2016-08-29 14:13:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278493004/80001
4 years, 3 months ago (2016-08-29 14:44:51 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/132031)
4 years, 3 months ago (2016-08-29 15:32:29 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278493004/80001
4 years, 3 months ago (2016-08-29 15:38:14 UTC) #22
dsansome
(I unset the commit bit on this change to try fix a stuck CQ - ...
4 years, 3 months ago (2016-08-30 03:54:26 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278493004/80001
4 years, 3 months ago (2016-08-30 03:57:15 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-30 05:12:36 UTC) #28
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:14:33 UTC) #30
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/36ad7565635f6f8955b798c1f8e9313cafd156d6
Cr-Commit-Position: refs/heads/master@{#415140}

Powered by Google App Engine
This is Rietveld 408576698