Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2278483004: update Android auto-detection. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

update Android auto-detection. Clang defines __ANDROID__ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278483004 No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/f419781d378fd78a332fdf9dd5dda0ff65d3c07d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/core/SkPreConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/fiddle/fiddle_main.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
mtklein_C
4 years, 3 months ago (2016-08-25 14:39:58 UTC) #3
jcgregorio
lgtm
4 years, 3 months ago (2016-08-25 14:42:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278483004/1
4 years, 3 months ago (2016-08-25 14:44:11 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 15:44:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f419781d378fd78a332fdf9dd5dda0ff65d3c07d

Powered by Google App Engine
This is Rietveld 408576698