Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2278463002: Get rid of FrameSelection::moveTo() taking two VisiblePosition objects (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of FrameSelection::moveTo() taking two VisiblePosition objects This patch gets rid of |FrameSelection::moveTo()| taking two |VisiblePosition| objects since its call site is only one for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/e8087c7e76b36995f2a98c5ac0c8552ea7962536 Cr-Commit-Position: refs/heads/master@{#414266}

Patch Set 1 : 2016-08-24T17:07:58 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-24 08:45:40 UTC) #6
Xiaocheng
lgtm
4 years, 4 months ago (2016-08-24 09:04:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278463002/1
4 years, 3 months ago (2016-08-25 01:27:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 02:25:25 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 02:28:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8087c7e76b36995f2a98c5ac0c8552ea7962536
Cr-Commit-Position: refs/heads/master@{#414266}

Powered by Google App Engine
This is Rietveld 408576698