Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6455)

Unified Diff: chrome/browser/ui/webui/theme_source.h

Issue 2278423002: Misc. cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bad merge Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/password_manager_list.js ('k') | chrome/browser/ui/webui/theme_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/theme_source.h
diff --git a/chrome/browser/ui/webui/theme_source.h b/chrome/browser/ui/webui/theme_source.h
index 6c0b4fcfbb0b9d351743f1d55dd4521acaeecbe2..22aee4be146291b8e608dd93bee84e991678ddd7 100644
--- a/chrome/browser/ui/webui/theme_source.h
+++ b/chrome/browser/ui/webui/theme_source.h
@@ -37,19 +37,17 @@ class ThemeSource : public content::URLDataSource {
bool ShouldServiceRequest(const net::URLRequest* request) const override;
private:
- // Fetch and send the theme bitmap.
+ // Fetches and sends the theme bitmap.
void SendThemeBitmap(const content::URLDataSource::GotDataCallback& callback,
int resource_id,
- float scale_factor);
+ float scale);
- // Similar to SendThemeBitmap but treat the responded data as image; if the
- // resource bundle does not contain the data for |scale_factor|, the resource
- // bundle falls back to the data of a lower scale, which means smaller images
- // will be served and webui handles the image incorrectly.
- // See crbug.com/442384.
+ // Used in place of SendThemeBitmap when the desired scale is larger than
+ // what the resource bundle supports. This can rescale the provided bitmap up
+ // to the desired size.
void SendThemeImage(const content::URLDataSource::GotDataCallback& callback,
int resource_id,
- float scale_factor);
+ float scale);
// The original profile (never an OTR profile).
Profile* profile_;
« no previous file with comments | « chrome/browser/resources/options/password_manager_list.js ('k') | chrome/browser/ui/webui/theme_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698