Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_subpage.html

Issue 2278413004: [MD settings] padding at the bottom of sub-pages (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-resizable-behavior /iron-resizable-behavior.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-resizable-behavior /iron-resizable-behavior.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable-behavior.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable-behavior.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
5 <link rel="import" href="/icons.html"> 5 <link rel="import" href="/icons.html">
6 <link rel="import" href="/route.html"> 6 <link rel="import" href="/route.html">
7 <link rel="import" href="/settings_page/settings_subpage_search.html"> 7 <link rel="import" href="/settings_page/settings_subpage_search.html">
8 <link rel="import" href="/settings_shared_css.html"> 8 <link rel="import" href="/settings_shared_css.html">
9 9
10 <dom-module id="settings-subpage"> 10 <dom-module id="settings-subpage">
(...skipping 16 matching lines...) Expand all
27 margin: 0 8px 0 -8px; 27 margin: 0 8px 0 -8px;
28 width: 36px; 28 width: 36px;
29 } 29 }
30 30
31 h1 { 31 h1 {
32 color: var(--settings-nav-grey); 32 color: var(--settings-nav-grey);
33 font-size: 107.6923%; /* go to 14px from 13px */ 33 font-size: 107.6923%; /* go to 14px from 13px */
34 font-weight: 500; 34 font-weight: 500;
35 } 35 }
36 36
37 #subpagePadding {
38 padding-bottom: 60px;
39 }
40
37 settings-subpage-search { 41 settings-subpage-search {
38 -webkit-margin-start: auto; 42 -webkit-margin-start: auto;
39 } 43 }
40 </style> 44 </style>
41 <div class="settings-box first"> 45 <div class="settings-box first">
42 <paper-icon-button icon="settings:arrow-back" on-tap="onTapBack_"> 46 <paper-icon-button icon="settings:arrow-back" on-tap="onTapBack_">
43 </paper-icon-button> 47 </paper-icon-button>
44 <h1>[[pageTitle]]</h1> 48 <h1>[[pageTitle]]</h1>
45 <template is="dom-if" if="[[searchLabel]]"> 49 <template is="dom-if" if="[[searchLabel]]">
46 <settings-subpage-search label="[[searchLabel]]" 50 <settings-subpage-search label="[[searchLabel]]"
47 on-search-changed="onSearchChanged_"> 51 on-search-changed="onSearchChanged_">
48 </settings-subpage-search> 52 </settings-subpage-search>
49 </template> 53 </template>
50 </div> 54 </div>
51 <content></content> 55 <content></content>
56 <div id="subpagePadding"></div>
tommycli 2016/08/29 16:38:39 Is it possible to put that padding on the content
Dan Beam 2016/08/29 17:34:45 the answer to this question ("can we slap a paddin
dschuyler 2016/08/29 18:20:51 Acknowledged.
dschuyler 2016/08/29 18:20:51 Done.
52 </template> 57 </template>
53 <script src="settings_subpage.js"></script> 58 <script src="settings_subpage.js"></script>
54 </dom-module> 59 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698