Make bookmark URLs not float left in RTL.

Make bookmark URLs not float left in RTL.

Now they are positioned just after (i.e. left of) the bookmark labels, just like
in LTR.

BUG=none
TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the URL for the bookmark is just left of the bookmark name, not all the way on the left side of the window.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e7c1b2121a2baf2ebb7cf93a2a669352a6059506
Cr-Commit-Position: refs/heads/master@{#415464}

[Peter Kasting, 2016-08-26 07:08:23]

Description was changed from

==========
Make bookmark URLs not float left in RTL.

Now they are positioned just after (i.e. left of) the bookmark labels, just like
in RTL.

BUG=none
TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the
URL for the bookmark is just left of the bookmark name, not all the way on the
left side of the window.
==========

to

==========
Make bookmark URLs not float left in RTL.

Now they are positioned just after (i.e. left of) the bookmark labels, just like
in RTL.

BUG=none
TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the
URL for the bookmark is just left of the bookmark name, not all the way on the
left side of the window.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Peter Kasting, 2016-08-26 07:08:27]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 07:08:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2016-08-26 07:09:19]

pkasting@chromium.org changed reviewers:
+ dbeam@chromium.org

[Peter Kasting, 2016-08-26 07:09:36]

Description was changed from

==========
Make bookmark URLs not float left in RTL.

Now they are positioned just after (i.e. left of) the bookmark labels, just like
in RTL.

BUG=none
TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the
URL for the bookmark is just left of the bookmark name, not all the way on the
left side of the window.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make bookmark URLs not float left in RTL.

Now they are positioned just after (i.e. left of) the bookmark labels, just like
in LTR.

BUG=none
TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the
URL for the bookmark is just left of the bookmark name, not all the way on the
left side of the window.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-26 09:25:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 09:25:10]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-08-29 16:35:47]

https://codereview.chromium.org/2278413002/diff/1/chrome/browser/resources/bo...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://codereview.chromium.org/2278413002/diff/1/chrome/browser/resources/bo...
chrome/browser/resources/bookmark_manager/css/bmm.css:60: text-align: right;
shouldn't we only be setting this in RTL?

[Peter Kasting, 2016-08-30 05:58:23]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 05:58:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2016-08-30 05:58:55]

PTAL

https://codereview.chromium.org/2278413002/diff/1/chrome/browser/resources/bo...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://codereview.chromium.org/2278413002/diff/1/chrome/browser/resources/bo...
chrome/browser/resources/bookmark_manager/css/bmm.css:60: text-align: right;
On 2016/08/29 16:35:47, Dan Beam wrote:
> shouldn't we only be setting this in RTL?

Yes... I have no explanation for this.

[commit-bot: I haz the power, 2016-08-30 08:30:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 08:30:15]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-08-30 22:25:31]

https://codereview.chromium.org/2278413002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://codereview.chromium.org/2278413002/diff/20001/chrome/browser/resource...
chrome/browser/resources/bookmark_manager/css/bmm.css:74: text-align: right;
fun fact: there's an directionally adaptive, non-standard version[1]

  text-align: start;

that would probably work for this.  it aligns to the logical start (i.e. LTR =>
left, RTL => right).

but there's really no reason to use it here because it's adding more rules to
the common, LTR case.

so lgtm

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/text-align

[Peter Kasting, 2016-08-30 22:28:04]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-08-30 22:28:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 22:35:11]

Description was changed from

==========
Make bookmark URLs not float left in RTL.

Now they are positioned just after (i.e. left of) the bookmark labels, just like
in LTR.

BUG=none
TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the
URL for the bookmark is just left of the bookmark name, not all the way on the
left side of the window.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make bookmark URLs not float left in RTL.

Now they are positioned just after (i.e. left of) the bookmark labels, just like
in LTR.

BUG=none
TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the
URL for the bookmark is just left of the bookmark name, not all the way on the
left side of the window.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-30 22:35:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 22:36:30]

Description was changed from

==========
Make bookmark URLs not float left in RTL.

Now they are positioned just after (i.e. left of) the bookmark labels, just like
in LTR.

BUG=none
TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the
URL for the bookmark is just left of the bookmark name, not all the way on the
left side of the window.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make bookmark URLs not float left in RTL.

Now they are positioned just after (i.e. left of) the bookmark labels, just like
in LTR.

BUG=none
TEST=Run chrome --lang=he, hit ctrl-shift-o, hover a bookmark, check that the
URL for the bookmark is just left of the bookmark name, not all the way on the
left side of the window.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e7c1b2121a2baf2ebb7cf93a2a669352a6059506
Cr-Commit-Position: refs/heads/master@{#415464}
==========

[commit-bot: I haz the power, 2016-08-30 22:36:31]

Patchset 2 (id:??) landed as
https://crrev.com/e7c1b2121a2baf2ebb7cf93a2a669352a6059506
Cr-Commit-Position: refs/heads/master@{#415464}