Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2278373002: Fix selectionEnd value in a case of dragging out from an INPUT element. (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix selectionEnd value in a case of dragging out from an INPUT element. In editing/selection/select-across-readonly-input-{1,4}.html, the end position is anchor=innerEditor type=AfterAnchor. indexFromPosition() didn't work well with such position. Committed: https://crrev.com/870cd879882b00d61a19b5ae006df3f8ab241cf3 Cr-Commit-Position: refs/heads/master@{#414680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h View 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
yosin@, would you review this please?
4 years, 3 months ago (2016-08-26 06:42:30 UTC) #7
yosin_UTC9
lgtm
4 years, 3 months ago (2016-08-26 09:29:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278373002/1
4 years, 3 months ago (2016-08-26 09:29:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 10:05:13 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 10:07:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/870cd879882b00d61a19b5ae006df3f8ab241cf3
Cr-Commit-Position: refs/heads/master@{#414680}

Powered by Google App Engine
This is Rietveld 408576698