third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html - Issue 2278303002: Remove the allow-displaying-mixed-content setting from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html

Issue 2278303002: Remove the allow-displaying-mixed-content setting from Blink. (Closed)

Patch Set: Cleanup before adding reviewers. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/native/aw_settings.cc ('K') | « third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-blocked.html ('k') | third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt » ('j') | third_party/WebKit/Source/core/loader/MixedContentChecker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html b/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html

index 88175fa3cbc5f39b891ce60a081c06049f8e3a31..9841771794212f430391156d55cdea87503599e0 100644

--- a/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html

+++ b/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html

@@ -6,8 +6,6 @@ if (window.testRunner) {

testRunner.dumpAsText();

testRunner.setCanOpenWindows();

testRunner.setCloseRemainingWindowsWhenComplete(true);

- testRunner.overridePreference("WebKitAllowDisplayingInsecureContent", false);

- testRunner.setAllowDisplayOfInsecureContent(true);

}

window.addEventListener("message", function (e) {

@@ -17,8 +15,7 @@ window.addEventListener("message", function (e) {

</script>

<p>This test opens a window that loads an insecure image. We should trigger

-a mixed content callback even though we've set the preference to block this,

-because we've overriden the preference via a web permission client callback.</p>

+a mixed content callback because passive mixed content is allowed by default.</p>

window.open("https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-image.html");

</script>